Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Issue 2958173003: [DevTools] Show ARIA pane based on whether AXNode is DOM node (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
index b3c30aef6c7a20a625627c599235a2760b9510eb..6dc7155421c87b2c57df28a6e06d0c315190c464 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
@@ -52,10 +52,10 @@ Accessibility.AccessibilitySidebarView = class extends UI.ThrottledWidget {
this._axNode = axNode;
- if (axNode.ignored())
- this._sidebarPaneStack.removeView(this._ariaSubPane);
- else
+ if (axNode.isDOMNode())
lushnikov 2017/06/28 18:21:00 What is "ignored" axNode? Should the condition be
aboxhall 2017/06/28 21:06:32 I deliberately removed that. Ignored means there i
this._sidebarPaneStack.showView(this._ariaSubPane, this._axNodeSubPane);
+ else
+ this._sidebarPaneStack.removeView(this._ariaSubPane);
if (this._axNodeSubPane)
this._axNodeSubPane.setAXNode(axNode);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698