Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2963473004: Generate type variable events before parsing return type. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate type variable events before parsing return type. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/616da7ea042662f6eb3ed74e4109637e12393d34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 3 chunks +17 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/unhandled_listener.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 5 months ago (2017-06-27 16:35:25 UTC) #2
danrubel
LGTM
3 years, 5 months ago (2017-06-28 03:26:07 UTC) #3
ahe
3 years, 5 months ago (2017-06-28 08:08:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
616da7ea042662f6eb3ed74e4109637e12393d34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698