Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2958023002: Add histograms and NetLog for host cache persistence (Closed)

Created:
3 years, 5 months ago by mgersh
Modified:
3 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, net-reviews_chromium.org, bnc+watch_chromium.org, asvitkine+watch_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histograms and NetLog for host cache persistence BUG=605149 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2958023002 Cr-Commit-Position: refs/heads/master@{#483526} Committed: https://chromium.googlesource.com/chromium/src/+/00eb7a2dfd3224a58de38a4a202b976e7f0b118f

Patch Set 1 #

Total comments: 2

Patch Set 2 : use scoped timer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -7 lines) Patch
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M components/cronet/host_cache_persistence_manager.h View 3 chunks +9 lines, -1 line 0 comments Download
M components/cronet/host_cache_persistence_manager.cc View 5 chunks +16 lines, -2 lines 0 comments Download
M components/cronet/host_cache_persistence_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/log/net_log_event_type_list.h View 1 chunk +19 lines, -0 lines 0 comments Download
M net/log/net_log_source_type_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (11 generated)
mgersh
I changed my mind and did this part as a separate CL instead.
3 years, 5 months ago (2017-06-27 14:19:39 UTC) #3
pauljensen
lgtm modulo one comment https://codereview.chromium.org/2958023002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/2958023002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc#newcode670 components/cronet/android/cronet_url_request_context_adapter.cc:670: prefs_init_end - prefs_init_start); { SCOPED_UMA_HISTOGRAM_TIMER("Net.Cronet.PrefsInitTime"); ...
3 years, 5 months ago (2017-06-28 14:12:01 UTC) #4
mgersh
holte: PTAL at histograms https://codereview.chromium.org/2958023002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/2958023002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc#newcode670 components/cronet/android/cronet_url_request_context_adapter.cc:670: prefs_init_end - prefs_init_start); On 2017/06/28 ...
3 years, 5 months ago (2017-06-28 14:21:08 UTC) #6
Steven Holte
lgtm
3 years, 5 months ago (2017-06-29 18:35:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958023002/20001
3 years, 5 months ago (2017-06-29 18:37:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/445799)
3 years, 5 months ago (2017-06-29 20:02:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958023002/20001
3 years, 5 months ago (2017-06-29 21:08:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet_tester/builds/1676)
3 years, 5 months ago (2017-06-29 22:06:46 UTC) #16
mgersh
On 2017/06/29 22:06:46, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 5 months ago (2017-06-29 22:07:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958023002/20001
3 years, 5 months ago (2017-06-29 22:20:55 UTC) #19
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 22:48:10 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00eb7a2dfd3224a58de38a4a202b...

Powered by Google App Engine
This is Rietveld 408576698