net/dns/host_cache.cc - Issue 2958023002: Add histograms and NetLog for host cache persistence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_cache.cc

Issue 2958023002: Add histograms and NetLog for host cache persistence (Closed)

Patch Set: use scoped timer Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/host_cache.cc

diff --git a/net/dns/host_cache.cc b/net/dns/host_cache.cc

index ce95a3143a3c454683978f36ee1b2221dadb71f7..460043f35c96cf419960cce7232ea907a0333d27 100644

--- a/net/dns/host_cache.cc

+++ b/net/dns/host_cache.cc

@@ -342,7 +342,6 @@ void HostCache::GetAsListValue(base::ListValue* entry_list,

}

-// TODO(mgersh): Add histograms to track failures.

bool HostCache::RestoreFromListValue(const base::ListValue& old_cache) {

for (auto it = old_cache.begin(); it != old_cache.end(); it++) {

const base::DictionaryValue* entry_dict;