Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2957943003: MD User manager: Migrate from PaperDialogBehavior to cr-dialog. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
Moe
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User manager: Migrate from PaperDialogBehavior to cr-dialog. BUG=720781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2957943003 Cr-Commit-Position: refs/heads/master@{#483122} Committed: https://chromium.googlesource.com/chromium/src/+/cecb193c19bf110b02072ec86f2ccb2e1088a258

Patch Set 1 #

Patch Set 2 : More work #

Patch Set 3 : Fix tests. #

Patch Set 4 : Restore color. #

Messages

Total messages: 17 (10 generated)
dpapad
Green tests at patch 3. Before/after screenshots at http://imgur.com/a/LaXQS.
3 years, 5 months ago (2017-06-27 22:20:54 UTC) #7
Moe
lgtm
3 years, 5 months ago (2017-06-28 15:14:42 UTC) #9
Moe
Won't wrapping of the focus on pressing tab be an issue with the cr-dialog as ...
3 years, 5 months ago (2017-06-28 15:16:14 UTC) #10
dpapad
On 2017/06/28 at 15:16:14, mahmadi wrote: > Won't wrapping of the focus on pressing tab ...
3 years, 5 months ago (2017-06-28 17:12:44 UTC) #11
Moe
On 2017/06/28 at 17:12:44, dpapad wrote: > On 2017/06/28 at 15:16:14, mahmadi wrote: > > ...
3 years, 5 months ago (2017-06-28 17:16:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957943003/60001
3 years, 5 months ago (2017-06-28 17:29:20 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 20:36:19 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cecb193c19bf110b02072ec86f2c...

Powered by Google App Engine
This is Rietveld 408576698