Provide feedback for multi-line selections

Provide feedback for multi-line selections

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2957653002
Cr-Commit-Position: refs/heads/master@{#482075}
Committed: https://chromium.googlesource.com/chromium/src/+/2f1b767b58201b9e51e71f32eb57c57e17bd4793

[David Tseng, 2017-06-23 18:16:34]

Description was changed from

==========
Provide feedback for multi-line selections

BUG=
==========

to

==========
Provide feedback for multi-line selections

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-23 18:16:58]

Description was changed from

==========
Provide feedback for multi-line selections

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Provide feedback for multi-line selections

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-23 18:16:59]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2017-06-23 18:21:17]

Patchset #2 (id:20001) has been deleted

[dmazzoni, 2017-06-23 19:50:49]

lgtm

https://codereview.chromium.org/2957653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2957653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:318:
cvox.ChromeVox.tts.speak(cur.selectedText, cvox.QueueMode.CATEGORY_FLUSH);
Do you want to do this if there's a lot of selected text?

[David Tseng, 2017-06-23 20:06:09]

Also, added a test. Thanks.

https://codereview.chromium.org/2957653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2957653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:318:
cvox.ChromeVox.tts.speak(cur.selectedText, cvox.QueueMode.CATEGORY_FLUSH);
On 2017/06/23 19:50:49, dmazzoni wrote:
> Do you want to do this if there's a lot of selected text?

I think this is ok since |cur| will be at most a line's worth of text. We can
revisit once others try it out.

[David Tseng, 2017-06-23 22:36:49]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-23 22:36:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2957653002/#ps60001
(title: "Add a test.")

[commit-bot: I haz the power, 2017-06-23 22:37:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 23:48:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498257409590430,
"parent_rev": "9d85f471065fb34745869cf4301ea8cd10aafcbe", "commit_rev":
"2f1b767b58201b9e51e71f32eb57c57e17bd4793"}

[commit-bot: I haz the power, 2017-06-23 23:48:38]

Description was changed from

==========
Provide feedback for multi-line selections

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Provide feedback for multi-line selections

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2957653002
Cr-Commit-Position: refs/heads/master@{#482075}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f1b767b58201b9e51e71f32eb57...
==========

[commit-bot: I haz the power, 2017-06-23 23:48:40]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2f1b767b58201b9e51e71f32eb57...