Turn on rich editable text by default

Turn on rich editable text by default

TEST=chromevox_tests Editing*.*
Manual:
 by character, word, line in complex html content editables
- navigation
- selection, deselection
- deletion

verify
- braille output: cursor/selection, line bounds (up to but not beyond the current line)
- speech output: text markers, styles, selection/deselection, deletion announcements
- corner cases: end of line, selection spanning
multiple lines.
- complex html: basic output for selections over non-textual content utilizing Output

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956663002
Cr-Commit-Position: refs/heads/master@{#482050}
Committed: https://chromium.googlesource.com/chromium/src/+/d919876ae05ce9d17ee8989543ae96d4b03176ac

[David Tseng, 2017-06-23 16:45:10]

Description was changed from

==========
Turn on rich editable text by default

TEST=chromevox_tests Editing*.*
Manual:
 by character, word, line in complex html content editables
- navigation
- selection, deselection
- deletion

verify
- braille output: cursor/selection, line bounds (up to but not beyond the
current line)
- speech output: text markers, styles, selection/deselection, deletion
announcements
- corner cases: end of line, selection spanning
multiple lines.
- complex html: basic output for selections over non-textual content utilizing
Output

BUG=
==========

to

==========
Turn on rich editable text by default

TEST=chromevox_tests Editing*.*
Manual:
 by character, word, line in complex html content editables
- navigation
- selection, deselection
- deletion

verify
- braille output: cursor/selection, line bounds (up to but not beyond the
current line)
- speech output: text markers, styles, selection/deselection, deletion
announcements
- corner cases: end of line, selection spanning
multiple lines.
- complex html: basic output for selections over non-textual content utilizing
Output

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-23 16:45:57]

Description was changed from

==========
Turn on rich editable text by default

TEST=chromevox_tests Editing*.*
Manual:
 by character, word, line in complex html content editables
- navigation
- selection, deselection
- deletion

verify
- braille output: cursor/selection, line bounds (up to but not beyond the
current line)
- speech output: text markers, styles, selection/deselection, deletion
announcements
- corner cases: end of line, selection spanning
multiple lines.
- complex html: basic output for selections over non-textual content utilizing
Output

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Turn on rich editable text by default

TEST=chromevox_tests Editing*.*
Manual:
 by character, word, line in complex html content editables
- navigation
- selection, deselection
- deletion

verify
- braille output: cursor/selection, line bounds (up to but not beyond the
current line)
- speech output: text markers, styles, selection/deselection, deletion
announcements
- corner cases: end of line, selection spanning
multiple lines.
- complex html: basic output for selections over non-textual content utilizing
Output

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-23 16:45:58]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-06-23 18:36:01]

lgtm

https://codereview.chromium.org/2956663002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2956663002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:393:
this.node_.find({role: RoleType.STATIC_TEXT})) {
I think this assumes that the first static text is the
same as the first line, which isn't necessarily true.
You could have a contenteditable where the first "line"
is an image, then the next "line" is the first line of
a paragraph.

How about using a more general way to determine this is
the first line?

[David Tseng, 2017-06-23 18:44:28]

https://codereview.chromium.org/2956663002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2956663002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:393:
this.node_.find({role: RoleType.STATIC_TEXT})) {
On 2017/06/23 18:36:01, dmazzoni wrote:
> I think this assumes that the first static text is the
> same as the first line, which isn't necessarily true.
> You could have a contenteditable where the first "line"
> is an image, then the next "line" is the first line of
> a paragraph.
> 
> How about using a more general way to determine this is
> the first line?

To be internally consistent with EditableLine, we would look for the first
inline text box to equal cur.lineStart_. Still doesn't address your concern
though and it also won't work at times because the inline text box gets
destroyed frequently. Do you have a generic way to know if a node can get
selection? The first leaf node is not really the answer I'm looking for.

[David Tseng, 2017-06-23 19:11:43]

On 2017/06/23 18:44:28, David Tseng wrote:
>
https://codereview.chromium.org/2956663002/diff/60001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
> (right):
> 
>
https://codereview.chromium.org/2956663002/diff/60001/chrome/browser/resource...
> chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:393:
> this.node_.find({role: RoleType.STATIC_TEXT})) {
> On 2017/06/23 18:36:01, dmazzoni wrote:
> > I think this assumes that the first static text is the
> > same as the first line, which isn't necessarily true.
> > You could have a contenteditable where the first "line"
> > is an image, then the next "line" is the first line of
> > a paragraph.
> > 
> > How about using a more general way to determine this is
> > the first line?
> 
> To be internally consistent with EditableLine, we would look for the first
> inline text box to equal cur.lineStart_. Still doesn't address your concern
> though and it also won't work at times because the inline text box gets
> destroyed frequently. Do you have a generic way to know if a node can get
> selection? The first leaf node is not really the answer I'm looking for.

I went ahead and reverted the braille first line changes. I have another idea to
indicate braille editability (flashing cursor).

[David Tseng, 2017-06-23 21:00:44]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-23 21:00:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2956663002/#ps100001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-06-23 21:01:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 22:27:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498251644508460,
"parent_rev": "56bb5fc503729068abf622d0e8a8f729297ff265", "commit_rev":
"d919876ae05ce9d17ee8989543ae96d4b03176ac"}

[commit-bot: I haz the power, 2017-06-23 22:27:12]

Description was changed from

==========
Turn on rich editable text by default

TEST=chromevox_tests Editing*.*
Manual:
 by character, word, line in complex html content editables
- navigation
- selection, deselection
- deletion

verify
- braille output: cursor/selection, line bounds (up to but not beyond the
current line)
- speech output: text markers, styles, selection/deselection, deletion
announcements
- corner cases: end of line, selection spanning
multiple lines.
- complex html: basic output for selections over non-textual content utilizing
Output

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Turn on rich editable text by default

TEST=chromevox_tests Editing*.*
Manual:
 by character, word, line in complex html content editables
- navigation
- selection, deselection
- deletion

verify
- braille output: cursor/selection, line bounds (up to but not beyond the
current line)
- speech output: text markers, styles, selection/deselection, deletion
announcements
- corner cases: end of line, selection spanning
multiple lines.
- complex html: basic output for selections over non-textual content utilizing
Output

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956663002
Cr-Commit-Position: refs/heads/master@{#482050}
Committed:
https://chromium.googlesource.com/chromium/src/+/d919876ae05ce9d17ee8989543ae...
==========

[commit-bot: I haz the power, 2017-06-23 22:27:14]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d919876ae05ce9d17ee8989543ae...