Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2957603002: [CSS Typed OM] Re-implement ToCSSValue and AsMatrix for CSSRotation (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 5 months ago
Reviewers:
nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Re-implement ToCSSValue and AsMatrix for CSSRotation I previously commented these out when I deleted obsolete number and length types, but now I can put it back. Added tests, and also removed a test that didn't seem useful. BUG=545318 Review-Url: https://codereview.chromium.org/2957603002 Cr-Commit-Position: refs/heads/master@{#484232} Committed: https://chromium.googlesource.com/chromium/src/+/64aec75f118e7130022f47b58d03e961a0f89b6d

Patch Set 1 #

Patch Set 2 : Merge branch 'csstransformcomponent-structure' into cssrotation-asmatrix #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Messages

Total messages: 13 (7 generated)
meade_UTC10
Hi nainar, PTAL
3 years, 6 months ago (2017-06-23 09:06:50 UTC) #2
nainar
lgtm
3 years, 5 months ago (2017-06-25 23:54:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957603002/80001
3 years, 5 months ago (2017-07-05 07:02:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/448158)
3 years, 5 months ago (2017-07-05 08:07:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957603002/80001
3 years, 5 months ago (2017-07-05 08:37:32 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 10:01:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/64aec75f118e7130022f47b58d03...

Powered by Google App Engine
This is Rietveld 408576698