Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSRotation.h

Issue 2957603002: [CSS Typed OM] Re-implement ToCSSValue and AsMatrix for CSSRotation (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSRotation.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSRotation.h b/third_party/WebKit/Source/core/css/cssom/CSSRotation.h
index 818bba79b5bf1f546aabbdad0a79f241dc36b279..6aa70d20be061810ab8fc3d0097b49a5305b71e7 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSRotation.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSRotation.h
@@ -49,16 +49,7 @@ class CORE_EXPORT CSSRotation final : public CSSTransformComponent {
// Internal methods - from CSSTransformComponent.
TransformComponentType GetType() const final { return kRotationType; }
- DOMMatrix* AsMatrix() const final {
- return nullptr;
- // TODO(meade): Implement.
- // return z_ == 1 ?
- // ? CSSMatrixComponent::Rotate(
- // angle_->to(CSSPrimitiveValue::UnitType::kDegrees)->value())
- // : CSSMatrixComponent::Rotate3d(
- // angle_->to(CSSPrimitiveValue::UnitType::kDegrees)->value(),
- // x_, y_, z_);
- }
+ DOMMatrix* AsMatrix() const final;
CSSFunctionValue* ToCSSValue() const final;
DEFINE_INLINE_VIRTUAL_TRACE() {

Powered by Google App Engine
This is Rietveld 408576698