Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2957523002: build: Remove build system support for gold plugin, except under ChromeOS, take 2. (Closed)

Created:
3 years, 6 months ago by pcc1
Modified:
3 years, 6 months ago
Reviewers:
Mark Seaborn, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Remove build system support for gold plugin, except under ChromeOS, take 2. Previous attempt: https://codereview.chromium.org/2891843002 This attempt includes a fix for //chrome/test/data/nacl/BUILD.gn in official builds. R=thakis@chromium.org TBR=mseaborn@chromium.org BUG=607968 Review-Url: https://codereview.chromium.org/2957523002 Cr-Commit-Position: refs/heads/master@{#481814} Committed: https://chromium.googlesource.com/chromium/src/+/0f268cb3af337cf608bd1902148a84195837ad1b

Patch Set 1 #

Patch Set 2 : New patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 chunk +8 lines, -0 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/nacl/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/win/DebugVisualizers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
pcc1
3 years, 6 months ago (2017-06-23 03:32:01 UTC) #1
Nico
lgtm
3 years, 6 months ago (2017-06-23 03:34:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957523002/20001
3 years, 6 months ago (2017-06-23 03:44:26 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/206250)
3 years, 6 months ago (2017-06-23 04:49:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957523002/20001
3 years, 6 months ago (2017-06-23 04:52:42 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 05:47:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f268cb3af337cf608bd1902148a...

Powered by Google App Engine
This is Rietveld 408576698