Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2957433002: Use SequencedTaskRunner rather than SingledThreadedTaskRunner for passing io_task_runner (Closed)

Created:
3 years, 6 months ago by eroman
Modified:
3 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, mac-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SequencedTaskRunner rather than SingledThreadedTaskRunner for passing io_task_runner to ProxyConfigService. In practice the io_task_runner will be a SingleThreadedTaskRunner, but this thread affinity doesn't need to be a contractual guarantee for ProxyConfigService implementations. BUG=735368 Review-Url: https://codereview.chromium.org/2957433002 Cr-Commit-Position: refs/heads/master@{#481955} Committed: https://chromium.googlesource.com/chromium/src/+/98e76eb9375e2db29291163aeec9f0bdf9ff85cb

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : undo change to glib_task_runner (keep it SingleThreadBlaBla) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M net/proxy/proxy_config_service_linux.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_mac.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (15 generated)
eroman
3 years, 6 months ago (2017-06-23 01:44:41 UTC) #13
mmenke
LGTM!
3 years, 6 months ago (2017-06-23 15:20:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957433002/40001
3 years, 6 months ago (2017-06-23 18:01:20 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 18:07:19 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/98e76eb9375e2db29291163aeec9...

Powered by Google App Engine
This is Rietveld 408576698