Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2946343003: Remove more instances of BrowserThread::FILE. (Closed)

Created:
3 years, 6 months ago by eroman
Modified:
3 years, 6 months ago
Reviewers:
Mike West, sky, mmenke
CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove more instances of BrowserThread::FILE. These existed to support ProxyConfigServiceLinux, which used to require a SingleThreadTaskRunner for FILE (but was recently removed). TBR=sky@chromium.org,mkwst@chromium.org BUG=689520 Review-Url: https://codereview.chromium.org/2946343003 Cr-Commit-Position: refs/heads/master@{#481711} Committed: https://chromium.googlesource.com/chromium/src/+/d3bd31fdd98cd0b900581d77953eeaa3e25337ad

Patch Set 1 #

Total comments: 1

Patch Set 2 : this time with feeling #

Messages

Total messages: 25 (14 generated)
eroman
https://codereview.chromium.org/2946343003/diff/1/content/shell/browser/shell_url_request_context_getter.h File content/shell/browser/shell_url_request_context_getter.h (left): https://codereview.chromium.org/2946343003/diff/1/content/shell/browser/shell_url_request_context_getter.h#oldcode37 content/shell/browser/shell_url_request_context_getter.h:37: // TODO(eroman): Remove the file_task_runner parameter (unused). This CL ...
3 years, 6 months ago (2017-06-22 20:14:11 UTC) #5
mmenke
Looks like you have more yet to do. Fun, fun.
3 years, 6 months ago (2017-06-22 20:20:17 UTC) #8
eroman
Sorry, I was overly optimistic that I had caught all the compile dependencies :( Will ...
3 years, 6 months ago (2017-06-22 20:24:00 UTC) #9
mmenke
Not a problem. Done that more than a few times myself. :)
3 years, 6 months ago (2017-06-22 20:26:27 UTC) #10
eroman
PTAL (trybots looking good so far)
3 years, 6 months ago (2017-06-22 21:18:34 UTC) #13
mmenke
On 2017/06/22 21:18:34, eroman wrote: > PTAL (trybots looking good so far) LGTM!
3 years, 6 months ago (2017-06-22 21:20:46 UTC) #14
eroman
TBR mkwst and sky: mkwst: content/shell/browser/layout_test/layout_test_browser_context.cc content/shell/browser/layout_test/layout_test_url_request_context_getter.cc content/shell/browser/layout_test/layout_test_url_request_context_getter.h content/shell/browser/shell_browser_context.cc content/shell/browser/shell_url_request_context_getter.cc content/shell/browser/shell_url_request_context_getter.h sky: content/shell/browser/layout_test/layout_test_browser_context.cc content/shell/browser/layout_test/layout_test_url_request_context_getter.cc content/shell/browser/layout_test/layout_test_url_request_context_getter.h ...
3 years, 6 months ago (2017-06-22 22:19:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946343003/20001
3 years, 6 months ago (2017-06-22 22:21:16 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d3bd31fdd98cd0b900581d77953eeaa3e25337ad
3 years, 6 months ago (2017-06-22 23:16:35 UTC) #23
sky
LGTM
3 years, 6 months ago (2017-06-23 03:25:01 UTC) #24
Mike West
3 years, 6 months ago (2017-06-23 06:44:32 UTC) #25
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698