Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 295713002: Rename SkMatrix::get(Min|Max)Stretch to get(Min|Max)Scale (Closed)

Created:
6 years, 7 months ago by bsalomon
Modified:
6 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Rename SkMatrix::get(Max|Min)Stretch to get(Min|Max)Scale Committed: http://code.google.com/p/skia/source/detail?r=14798

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M include/core/SkMatrix.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/MatrixTest.cpp View 1 2 5 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
I want to add a version that gets both and decided I like "scale" better ...
6 years, 7 months ago (2014-05-20 14:13:04 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-20 14:43:13 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-05-20 14:44:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/295713002/40001
6 years, 7 months ago (2014-05-20 14:45:03 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 14:53:49 UTC) #5
Message was sent while issue was closed.
Change committed as 14798

Powered by Google App Engine
This is Rietveld 408576698