Add 'Updated just now' timestamp to the Previews infobar

Add 'Updated just now' timestamp to the Previews infobar

When a stale preview is refreshed, show a 'Updated just now' timestamp
on the infobar.

BUG=718643
Review-Url: https://codereview.chromium.org/2956733002
Cr-Commit-Position: refs/heads/master@{#482094}
Committed: https://chromium.googlesource.com/chromium/src/+/7e19dfa32df45d1541fde8f76bcf8eb819889c0c

[megjablon, 2017-06-23 22:58:34]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 22:59:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-23 23:01:27]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[megjablon, 2017-06-23 23:01:37]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-23 23:01:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-23 23:01:51]

megjablon@chromium.org changed reviewers:
+ tbansal@chromium.org

[megjablon, 2017-06-23 23:01:51]

PTAL, thanks!

[tbansal1, 2017-06-23 23:13:32]

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
File chrome/browser/previews/previews_infobar_delegate.h (right):

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
chrome/browser/previews/previews_infobar_delegate.h:87:
PreviewsInfoBarTabHelper* infobar_tab_helper_;
Is this guaranteed to be non-null? May be add a comment on the lifetime.

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
File chrome/browser/previews/previews_infobar_tab_helper.cc (right):

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
chrome/browser/previews/previews_infobar_tab_helper.cc:79:
displayed_preview_timestamp_ = false;
What happens if the page is reloaded more than once?
Would we show the new string on the second or third reload?

[tbansal1, 2017-06-23 23:24:09]

lgtm % comments.

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
File chrome/browser/previews/previews_infobar_delegate.cc (right):

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
chrome/browser/previews/previews_infobar_delegate.cc:292: return
l10n_util::GetStringUTF16(
consider adding:
  infobar_tab_helper_->set_displayed_preview_timestamp(true);

[megjablon, 2017-06-23 23:37:11]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 23:37:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-23 23:39:24]

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
File chrome/browser/previews/previews_infobar_delegate.cc (right):

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
chrome/browser/previews/previews_infobar_delegate.cc:292: return
l10n_util::GetStringUTF16(
On 2017/06/23 23:24:08, tbansal1 wrote:
> consider adding:
>   infobar_tab_helper_->set_displayed_preview_timestamp(true);

Done.

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
File chrome/browser/previews/previews_infobar_delegate.h (right):

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
chrome/browser/previews/previews_infobar_delegate.h:87:
PreviewsInfoBarTabHelper* infobar_tab_helper_;
On 2017/06/23 23:13:31, tbansal1 wrote:
> Is this guaranteed to be non-null? May be add a comment on the lifetime.

Added a check in GetTimestampText instead. With the infobar lifetime also tied
to a WebContentsOberser, we can guarantee the order of destruction.

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
File chrome/browser/previews/previews_infobar_tab_helper.cc (right):

https://codereview.chromium.org/2956733002/diff/20001/chrome/browser/previews...
chrome/browser/previews/previews_infobar_tab_helper.cc:79:
displayed_preview_timestamp_ = false;
On 2017/06/23 23:13:31, tbansal1 wrote:
> What happens if the page is reloaded more than once?
> Would we show the new string on the second or third reload?

With your comment in previews_infobar_delegate.cc, As long as the user waited
for the infobar to be shown and set this true again, then the string will also
be shown again.

[megjablon, 2017-06-23 23:46:47]

The CQ bit was unchecked by megjablon@chromium.org

[megjablon, 2017-06-23 23:46:48]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2017-06-23 23:46:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/2956733002/#ps40001
(title: "tbansal comments")

[commit-bot: I haz the power, 2017-06-23 23:47:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 00:47:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498261608434440,
"parent_rev": "1f547f2e280b4cb80921832f94b7ccd1cceec760", "commit_rev":
"7e19dfa32df45d1541fde8f76bcf8eb819889c0c"}

[commit-bot: I haz the power, 2017-06-24 00:47:33]

Description was changed from

==========
Add 'Updated just now' timestamp to the Previews infobar

When a stale preview is refreshed, show a 'Updated just now' timestamp
on the infobar.

BUG=718643
==========

to

==========
Add 'Updated just now' timestamp to the Previews infobar

When a stale preview is refreshed, show a 'Updated just now' timestamp
on the infobar.

BUG=718643

Review-Url: https://codereview.chromium.org/2956733002
Cr-Commit-Position: refs/heads/master@{#482094}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e19dfa32df45d1541fde8f76bcf...
==========

[commit-bot: I haz the power, 2017-06-24 00:47:34]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7e19dfa32df45d1541fde8f76bcf...