Add 'Updated just now' timestamp to the Previews infobar

chrome/browser/previews/previews_infobar_tab_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/previews/previews_infobar_tab_helper.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "chrome/browser/loader/chrome_navigation_data.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
@@ skipping 40 matching lines @@
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(PreviewsInfoBarTabHelper);
 
 PreviewsInfoBarTabHelper::~PreviewsInfoBarTabHelper() {
   ClearLastNavigationAsync();
 }
 
 PreviewsInfoBarTabHelper::PreviewsInfoBarTabHelper(
     content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       browser_context_(web_contents->GetBrowserContext()),
-      displayed_preview_infobar_(false) {
+      displayed_preview_infobar_(false),
+      displayed_preview_timestamp_(false) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 }
 
 void PreviewsInfoBarTabHelper::DidFinishNavigation(
     content::NavigationHandle* navigation_handle) {
   // Only show the infobar if this is a full main frame navigation.
   if (!navigation_handle->IsInMainFrame() ||
       !navigation_handle->HasCommitted() || navigation_handle->IsSameDocument())
     return;
+  // The infobar should only be told if the page was a reload if the previous
+  // page displayed a timestamp.
+  bool is_reload =
+      displayed_preview_timestamp_
+          ? navigation_handle->GetReloadType() != content::ReloadType::NONE
+          : false;
   displayed_preview_infobar_ = false;
+  displayed_preview_timestamp_ = false;

[tbansal1, 2017/06/23 23:13:31]

What happens if the page is reloaded more than once?
Would we show the new string on the second or third reload?

[megjablon, 2017/06/23 23:39:24]

With your comment in previews_infobar_delegate.cc, As long as the user waited
for the infobar to be shown and set this true again, then the string will also
be shown again.

   ClearLastNavigationAsync();
   committed_data_saver_navigation_id_.reset();
 
   // As documented in content/public/browser/navigation_handle.h, this
   // NavigationData is a clone of the NavigationData instance returned from
   // ResourceDispatcherHostDelegate::GetNavigationData during commit.
   // Because ChromeResourceDispatcherHostDelegate always returns a
   // ChromeNavigationData, it is safe to static_cast here.
   ChromeNavigationData* chrome_navigation_data =
       static_cast<ChromeNavigationData*>(
@@ skipping 16 matching lines @@
     if (navigation_handle->IsErrorPage()) {
       // TODO(ryansturm): Add UMA for errors.
       return;
     }
     data_reduction_proxy::DataReductionProxySettings*
         data_reduction_proxy_settings =
             DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
                 web_contents()->GetBrowserContext());
     PreviewsInfoBarDelegate::Create(
         web_contents(), previews::PreviewsType::OFFLINE,
-        base::Time() /* previews_freshness */,
+        base::Time() /* previews_freshness */, false /* is_reload */,
         data_reduction_proxy_settings &&
             data_reduction_proxy_settings->IsDataReductionProxyEnabled(),
         base::Bind(&AddPreviewNavigationCallback, browser_context_,
                    navigation_handle->GetRedirectChain()[0],
                    previews::PreviewsType::OFFLINE));
     // Don't try to show other infobars if this is an offline preview.
     return;
   }
 #endif  // defined(OS_ANDROID)
 
   const net::HttpResponseHeaders* headers =
       navigation_handle->GetResponseHeaders();
   if (headers && data_reduction_proxy::IsLitePagePreview(*headers)) {
     base::Time previews_freshness;
     headers->GetDateValue(&previews_freshness);
     PreviewsInfoBarDelegate::Create(
         web_contents(), previews::PreviewsType::LITE_PAGE, previews_freshness,
-        true /* is_data_saver_user */,
+        true /* is_data_saver_user */, is_reload,
         base::Bind(&AddPreviewNavigationCallback, browser_context_,
                    navigation_handle->GetRedirectChain()[0],
                    previews::PreviewsType::LITE_PAGE));
   }
 }
 
 void PreviewsInfoBarTabHelper::ClearLastNavigationAsync() const {
   if (!committed_data_saver_navigation_id_)
     return;
   auto* data_reduction_proxy_settings =
       DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
           browser_context_);
   if (!data_reduction_proxy_settings ||
       !data_reduction_proxy_settings->data_reduction_proxy_service()) {
     return;
   }
   data_reduction_proxy_settings->data_reduction_proxy_service()
       ->pingback_client()
       ->ClearNavigationKeyAsync(committed_data_saver_navigation_id_.value());
 }