Fix end of line announcements

Fix end of line announcements

- fix Cursor.deepEquivalent to account for end of line selection offset.
- add Cursor.deepEquivalent test coverage.
- add spoken feedback for end of line.
- add test coverage for end of line output.

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2948173004
Cr-Commit-Position: refs/heads/master@{#482021}
Committed: https://chromium.googlesource.com/chromium/src/+/1f6bad48f3576c037c6863cda89e6a178fe30e5e

[David Tseng, 2017-06-21 23:17:45]

Description was changed from

==========
Fix end of line announcements

- fix Cursor.deepEquivalent to account for end of line selection offset.
- add Cursor.deepEquivalent test coverage.
- add spoken feedback for end of line.
- add test coverage for end of line output.

BUG=
==========

to

==========
Fix end of line announcements

- fix Cursor.deepEquivalent to account for end of line selection offset.
- add Cursor.deepEquivalent test coverage.
- add spoken feedback for end of line.
- add test coverage for end of line output.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-21 23:18:19]

Description was changed from

==========
Fix end of line announcements

- fix Cursor.deepEquivalent to account for end of line selection offset.
- add Cursor.deepEquivalent test coverage.
- add spoken feedback for end of line.
- add test coverage for end of line output.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix end of line announcements

- fix Cursor.deepEquivalent to account for end of line selection offset.
- add Cursor.deepEquivalent test coverage.
- add spoken feedback for end of line.
- add test coverage for end of line output.

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-21 23:18:19]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-06-23 18:31:45]

lgtm

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:396: //
the character to the right, this state has very little meaning in most
I don't know what you mean by "this state has very little meaning".
Would it be sufficient to just say "Describe it as a new line"?

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
(right):

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:404:
.expectSpeech('\n')
Who translates this character into "end of line", is it done
later in ChromeVox, or by the TTS engine?

[David Tseng, 2017-06-23 19:17:07]

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
(right):

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js:396: //
the character to the right, this state has very little meaning in most
On 2017/06/23 18:31:45, dmazzoni wrote:
> I don't know what you mean by "this state has very little meaning".
> Would it be sufficient to just say "Describe it as a new line"?

It has little meaning because there's no character to the right on the same
line.
I removed the comment.

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
(right):

https://codereview.chromium.org/2948173004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:404:
.expectSpeech('\n')
On 2017/06/23 18:31:45, dmazzoni wrote:
> Who translates this character into "end of line", is it done
> later in ChromeVox, or by the TTS engine?

We localize it (see abstract_tts.js).

[David Tseng, 2017-06-23 19:20:21]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-23 19:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2948173004/#ps20001
(title: "Remove comment.")

[commit-bot: I haz the power, 2017-06-23 19:20:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 20:50:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498245621361970,
"parent_rev": "842496b2b667375551048501350b0789e8585878", "commit_rev":
"1f6bad48f3576c037c6863cda89e6a178fe30e5e"}

[commit-bot: I haz the power, 2017-06-23 20:51:08]

Description was changed from

==========
Fix end of line announcements

- fix Cursor.deepEquivalent to account for end of line selection offset.
- add Cursor.deepEquivalent test coverage.
- add spoken feedback for end of line.
- add test coverage for end of line output.

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix end of line announcements

- fix Cursor.deepEquivalent to account for end of line selection offset.
- add Cursor.deepEquivalent test coverage.
- add spoken feedback for end of line.
- add test coverage for end of line output.

BUG=719654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2948173004
Cr-Commit-Position: refs/heads/master@{#482021}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f6bad48f3576c037c6863cda89e...
==========

[commit-bot: I haz the power, 2017-06-23 20:51:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f6bad48f3576c037c6863cda89e...