[Payment Request] Makes sure only complete credit cards can be selected

[Payment Request] Makes sure only complete credit cards can be selected.

- Checks the credit cards for completeness before setting the default
  selected credit card.
- Allows selection of complete credit cards only.

BUG=602666, 714768
Review-Url: https://codereview.chromium.org/2956453003
Cr-Commit-Position: refs/heads/master@{#482629}
Committed: https://chromium.googlesource.com/chromium/src/+/43f2fb2e67d2d50f5134301a2a78d9d890bb6c61

[Moe, 2017-06-26 17:31:40]

Description was changed from

==========
WIP [Payment Request] Makes sure only complete credit cards can be selected

Checks the credit cards for completeness before setting the default
selected credit card. Allows selection of complete credit cards only.

BUG=602666
==========

to

==========
- Checks the credit cards for completeness before setting the default
selected credit card.
- Allows selection of complete credit cards only.

BUG=602666, 714768
==========

[Moe, 2017-06-26 17:31:40]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-06-26 17:31:46]

Patchset #1 (id:1) has been deleted

[Moe, 2017-06-26 17:31:53]

Patchset #1 (id:20001) has been deleted

[Moe, 2017-06-26 17:32:21]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 17:32:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-06-26 17:32:51]

Hi Rouslan, Please take a look.

[commit-bot: I haz the power, 2017-06-26 17:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 17:45:06]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-06-26 17:46:38]

Description was changed from

==========
- Checks the credit cards for completeness before setting the default
selected credit card.
- Allows selection of complete credit cards only.

BUG=602666, 714768
==========

to

==========
[Payment Request] Makes sure only complete credit cards can be selected.

- Checks the credit cards for completeness before setting the default
  selected credit card.
- Allows selection of complete credit cards only.

BUG=602666, 714768
==========

[please use gerrit instead, 2017-06-26 17:54:21]

LGTM % comment

You may want to get someone fluent in Objective C to take a look as well.

https://codereview.chromium.org/2956453003/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_util.h (right):

https://codereview.chromium.org/2956453003/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_util.h:59: const
std::vector<autofill::AutofillProfile*> billing_profiles);
const-ref to avoid copying std::vector.

https://codereview.chromium.org/2956453003/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_util.h:65: const
std::vector<autofill::AutofillProfile*> billing_profiles);
const-ref to avoid copying std::vector.

[Moe, 2017-06-26 20:17:59]

mahmadi@chromium.org changed reviewers:
+ jif@chromium.org

[Moe, 2017-06-26 20:18:00]

Hi JF, Could you please take a look with an Objective-C lens to make sure this
is A-OK?

https://codereview.chromium.org/2956453003/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_util.h (right):

https://codereview.chromium.org/2956453003/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_util.h:59: const
std::vector<autofill::AutofillProfile*> billing_profiles);
On 2017/06/26 at 17:54:21, rouslan wrote:
> const-ref to avoid copying std::vector.

Done.

https://codereview.chromium.org/2956453003/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_util.h:65: const
std::vector<autofill::AutofillProfile*> billing_profiles);
On 2017/06/26 at 17:54:21, rouslan wrote:
> const-ref to avoid copying std::vector.

Done.

[jif, 2017-06-27 14:54:08]

lgtm

[Moe, 2017-06-27 15:02:16]

On 2017/06/27 at 14:54:08, jif wrote:
> lgtm

Thank you!

[Moe, 2017-06-27 15:02:20]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-06-27 15:02:21]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2956453003/#ps80001
(title: "Fixed unit test")

[commit-bot: I haz the power, 2017-06-27 15:02:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 15:16:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498575740818200,
"parent_rev": "949e4fe96e90ac91af5c8a26de9228a0d78ad2f4", "commit_rev":
"43f2fb2e67d2d50f5134301a2a78d9d890bb6c61"}

[commit-bot: I haz the power, 2017-06-27 15:16:27]

Description was changed from

==========
[Payment Request] Makes sure only complete credit cards can be selected.

- Checks the credit cards for completeness before setting the default
  selected credit card.
- Allows selection of complete credit cards only.

BUG=602666, 714768
==========

to

==========
[Payment Request] Makes sure only complete credit cards can be selected.

- Checks the credit cards for completeness before setting the default
  selected credit card.
- Allows selection of complete credit cards only.

BUG=602666, 714768

Review-Url: https://codereview.chromium.org/2956453003
Cr-Commit-Position: refs/heads/master@{#482629}
Committed:
https://chromium.googlesource.com/chromium/src/+/43f2fb2e67d2d50f5134301a2a78...
==========

[commit-bot: I haz the power, 2017-06-27 15:16:28]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/43f2fb2e67d2d50f5134301a2a78...