ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm - Issue 2956453003: [Payment Request] Makes sure only complete credit cards can be selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm

Issue 2956453003: [Payment Request] Makes sure only complete credit cards can be selected (Closed)

Patch Set: Fixed unit test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/payments/payment_method_selection_coordinator_unittest.mm ('k') | ios/chrome/browser/ui/payments/payment_request_coordinator.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm

diff --git a/ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm b/ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm

index 53f748aa784f87a78a3c66823cedec5f9b0d41e7..064fc62ac88d697ab3f2e53892113458cad55031 100644

--- a/ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm

+++ b/ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm

@@ -92,6 +92,11 @@ using ::payment_request_util::GetBillingAddressLabelFromAutofillProfile;

base::SysUTF16ToNSString(paymentMethod->NetworkAndLastFourDigits());

item.methodDetail = base::SysUTF16ToNSString(

paymentMethod->GetRawInfo(autofill::CREDIT_CARD_NAME_FULL));

+ item.notification =

+ payment_request_util::GetPaymentMethodNotificationLabelFromCreditCard(

+ *paymentMethod, _paymentRequest->billing_profiles());

+ item.complete = payment_request_util::IsCreditCardCompleteForPayment(

+ *paymentMethod, _paymentRequest->billing_profiles());

autofill::AutofillProfile* billingAddress =

autofill::PersonalDataManager::GetProfileFromProfilesByGUID(