Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2956443002: [Telemetry] Delete camel_case shim (Closed)

Created:
3 years, 6 months ago by eakuefner
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Delete camel_case shim There was previously a zombie module referring to telemetry.internal.util.camel_case, which has been moved to py_utils. As of https://codereview.chromium.org/2950373002 this will have been cleaned up, so the shim can be deleted. BUG=catapult:#3612 Review-Url: https://codereview.chromium.org/2956443002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6b73d036d3928634f7a2b2e62b416eea82cfc2a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M telemetry/telemetry/internal/util/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
eakuefner
Ned, please take a look. https://codereview.chromium.org/2950373002 should land in Chromium before this lands in Catapult.
3 years, 6 months ago (2017-06-22 17:09:29 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-22 17:22:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956443002/1
3 years, 6 months ago (2017-06-22 19:43:09 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 20:08:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698