Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2950373002: [Perf] Delete unused WebRTC stats metric (Closed)

Created:
3 years, 6 months ago by eakuefner
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, ehmaldonado_chromium
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Perf] Delete unused WebRTC stats metric This CL deletes the old, now-unused version of the WebRTC stats metric. This metric has long since been ported to TBMv2, and this version uses a library from Catapult that has been moved, so it is blocking the deletion of a shim. BUG=catapult:#3612 Review-Url: https://codereview.chromium.org/2950373002 Cr-Commit-Position: refs/heads/master@{#481629} Committed: https://chromium.googlesource.com/chromium/src/+/77dc24354a694fff6a9f9a6e270ae05b4f604f51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -346 lines) Patch
D tools/perf/metrics/webrtc_stats.py View 1 chunk +0 lines, -168 lines 0 comments Download
D tools/perf/metrics/webrtc_stats_unittest.py View 1 chunk +0 lines, -178 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
eakuefner
Ned, please take a look. After this CL lands in Chromium, https://codereview.chromium.org/2956443002 will remove the ...
3 years, 6 months ago (2017-06-22 17:09:00 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-22 17:22:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950373002/1
3 years, 6 months ago (2017-06-22 17:24:43 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 19:48:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77dc24354a694fff6a9f9a6e270a...

Powered by Google App Engine
This is Rietveld 408576698