[DevTools] Provide Target.targetInfoChanged notification

[DevTools] Provide Target.targetInfoChanged notification

This one currently triggers when attached bit has changed on target.
This moves node-specific logic to frontend, and simplifies backend
in preparation for multi-client.

BUG=590878
Review-Url: https://codereview.chromium.org/2956423003
Cr-Commit-Position: refs/heads/master@{#483495}
Committed: https://chromium.googlesource.com/chromium/src/+/af7a673ba20493cf63845a5506ba8d44d6e49ca3

[dgozman, 2017-06-28 22:51:05]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-06-28 22:51:17]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-06-28 22:51:17]

Could you please take a look?

[commit-bot: I haz the power, 2017-06-28 22:51:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 00:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 00:57:58]

Dry run: This issue passed the CQ dry run.

[caseq, 2017-06-29 20:36:17]

lgtm

https://codereview.chromium.org/2956423003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2956423003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:493: if
(!targetInfo.attached)
This is still prone to races. So perhaps try attaching anyway?

[dgozman, 2017-06-29 21:31:23]

https://codereview.chromium.org/2956423003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2956423003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:493: if
(!targetInfo.attached)
On 2017/06/29 20:36:17, caseq wrote:
> This is still prone to races. So perhaps try attaching anyway?

Acknowledged.

[dgozman, 2017-06-29 21:31:29]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-06-29 21:31:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 21:37:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498771889080200, "parent_rev":
"d1e96b7ddea88fa9219478bfbd04f94772e31718", "commit_rev":
"af7a673ba20493cf63845a5506ba8d44d6e49ca3"}

[commit-bot: I haz the power, 2017-06-29 21:37:47]

Description was changed from

==========
[DevTools] Provide Target.targetInfoChanged notification

This one currently triggers when attached bit has changed on target.
This moves node-specific logic to frontend, and simplifies backend
in preparation for multi-client.

BUG=590878
==========

to

==========
[DevTools] Provide Target.targetInfoChanged notification

This one currently triggers when attached bit has changed on target.
This moves node-specific logic to frontend, and simplifies backend
in preparation for multi-client.

BUG=590878

Review-Url: https://codereview.chromium.org/2956423003
Cr-Commit-Position: refs/heads/master@{#483495}
Committed:
https://chromium.googlesource.com/chromium/src/+/af7a673ba20493cf63845a5506ba...
==========

[commit-bot: I haz the power, 2017-06-29 21:37:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af7a673ba20493cf63845a5506ba...