[DevTools] Provide Target.targetInfoChanged notification

content/browser/devtools/protocol/devtools_protocol_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 1593 matching lines @@
                           ->GetController()
                           .GetLastCommittedEntry()
                           ->GetURL());
 }
 
 IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, TargetDiscovery) {
   std::string temp;
   std::set<std::string> ids;
   std::unique_ptr<base::DictionaryValue> command_params;
   std::unique_ptr<base::DictionaryValue> params;
+  bool is_attached;
 
   ASSERT_TRUE(embedded_test_server()->Start());
   GURL first_url = embedded_test_server()->GetURL("/devtools/navigation.html");
   NavigateToURLBlockUntilNavigationsComplete(shell(), first_url, 1);
 
   GURL second_url = embedded_test_server()->GetURL("/devtools/navigation.html");
   Shell* second = CreateBrowser();
   NavigateToURLBlockUntilNavigationsComplete(second, second_url, 1);
 
   Attach();
+  int attached_count = 0;
   command_params.reset(new base::DictionaryValue());
   command_params->SetBoolean("discover", true);
   SendCommand("Target.setDiscoverTargets", std::move(command_params), true);
   params = WaitForNotification("Target.targetCreated", true);
   EXPECT_TRUE(params->GetString("targetInfo.type", &temp));
   EXPECT_EQ("page", temp);
+  EXPECT_TRUE(params->GetBoolean("targetInfo.attached", &is_attached));
+  attached_count += is_attached ? 1 : 0;
   EXPECT_TRUE(params->GetString("targetInfo.targetId", &temp));
   EXPECT_TRUE(ids.find(temp) == ids.end());
   ids.insert(temp);
   params = WaitForNotification("Target.targetCreated", true);
   EXPECT_TRUE(params->GetString("targetInfo.type", &temp));
   EXPECT_EQ("page", temp);
+  EXPECT_TRUE(params->GetBoolean("targetInfo.attached", &is_attached));
+  attached_count += is_attached ? 1 : 0;
   EXPECT_TRUE(params->GetString("targetInfo.targetId", &temp));
   EXPECT_TRUE(ids.find(temp) == ids.end());
   ids.insert(temp);
   EXPECT_TRUE(notifications_.empty());
+  EXPECT_EQ(1, attached_count);
 
   GURL third_url = embedded_test_server()->GetURL("/devtools/navigation.html");
   Shell* third = CreateBrowser();
   NavigateToURLBlockUntilNavigationsComplete(third, third_url, 1);
   params = WaitForNotification("Target.targetCreated", true);
   EXPECT_TRUE(params->GetString("targetInfo.type", &temp));
   EXPECT_EQ("page", temp);
   EXPECT_TRUE(params->GetString("targetInfo.targetId", &temp));
   EXPECT_TRUE(ids.find(temp) == ids.end());
+  EXPECT_TRUE(params->GetBoolean("targetInfo.attached", &is_attached));
+  EXPECT_FALSE(is_attached);
   std::string attached_id = temp;
   ids.insert(temp);
   EXPECT_TRUE(notifications_.empty());
 
   second->Close();
   second = nullptr;
   params = WaitForNotification("Target.targetDestroyed", true);
   EXPECT_TRUE(params->GetString("targetId", &temp));
   EXPECT_TRUE(ids.find(temp) != ids.end());
   ids.erase(temp);
   EXPECT_TRUE(notifications_.empty());
 
   command_params.reset(new base::DictionaryValue());
   command_params->SetString("targetId", attached_id);
   SendCommand("Target.attachToTarget", std::move(command_params), true);
+  params = WaitForNotification("Target.targetInfoChanged", true);
+  EXPECT_TRUE(params->GetString("targetInfo.targetId", &temp));
+  EXPECT_EQ(attached_id, temp);
+  EXPECT_TRUE(params->GetBoolean("targetInfo.attached", &is_attached));
+  EXPECT_TRUE(is_attached);
   params = WaitForNotification("Target.attachedToTarget", true);
   EXPECT_TRUE(params->GetString("targetInfo.targetId", &temp));
   EXPECT_EQ(attached_id, temp);
   EXPECT_TRUE(notifications_.empty());
 
   command_params.reset(new base::DictionaryValue());
   command_params->SetBoolean("discover", false);
   SendCommand("Target.setDiscoverTargets", std::move(command_params), true);
   EXPECT_TRUE(notifications_.empty());
 
@@ skipping 156 matching lines @@
       EXPECT_EQ("polyglottal", value);
       found++;
     } else {
       FAIL();
     }
   }
   EXPECT_EQ(2u, found);
 }
 
 }  // namespace content