[Payment Request] Simplifies VC's logic to decide if an item is selectable

[Payment Request] Simplifies VC's logic to decide if an item is selectable

* The decision is made in the coordinator instead by return a boolean from
  -paymentRequestSelectorViewController:didSelectItemAtIndex: indicating
  whether selection can actually be made.
* Also fixes a bug where editing an item from the selector screen, in edit
  mode, without any previosuly selected items was causing a crash.

BUG=602666
Review-Url: https://codereview.chromium.org/2956323002
Cr-Commit-Position: refs/heads/master@{#483277}
Committed: https://chromium.googlesource.com/chromium/src/+/bb6441a2d4301c1048836c560a3f83e3b68df2c8

[Moe, 2017-06-28 17:18:57]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 17:19:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-06-28 17:19:21]

mahmadi@chromium.org changed reviewers:
+ macourteau@chromium.org

[Moe, 2017-06-28 17:19:21]

Hi MAC, Please take a look.

[commit-bot: I haz the power, 2017-06-28 17:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 17:37:05]

Dry run: This issue passed the CQ dry run.

[macourteau, 2017-06-28 19:11:42]

lgtm % nit

https://codereview.chromium.org/2956323002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_selector_view_controller.mm
(right):

https://codereview.chromium.org/2956323002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_selector_view_controller.mm:269:
DCHECK(index < [[self.dataSource selectableItems] count]);
nit: DCHECK_LT ?

[Moe, 2017-06-29 01:34:01]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-06-29 01:34:02]

Thank you.

https://codereview.chromium.org/2956323002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_selector_view_controller.mm
(right):

https://codereview.chromium.org/2956323002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_selector_view_controller.mm:269:
DCHECK(index < [[self.dataSource selectableItems] count]);
On 2017/06/28 at 19:11:42, macourteau wrote:
> nit: DCHECK_LT ?

Done.

[Moe, 2017-06-29 01:34:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
macourteau@chromium.org
Link to the patchset: https://codereview.chromium.org/2956323002/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-06-29 01:34:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 03:17:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498700041523590,
"parent_rev": "ffb4fbf926444cc3aecd111c98d1521993272593", "commit_rev":
"bb6441a2d4301c1048836c560a3f83e3b68df2c8"}

[commit-bot: I haz the power, 2017-06-29 03:18:04]

Description was changed from

==========
[Payment Request] Simplifies VC's logic to decide if an item is selectable

* The decision is made in the coordinator instead by return a boolean from
  -paymentRequestSelectorViewController:didSelectItemAtIndex: indicating
  whether selection can actually be made.
* Also fixes a bug where editing an item from the selector screen, in edit
  mode, without any previosuly selected items was causing a crash.

BUG=602666
==========

to

==========
[Payment Request] Simplifies VC's logic to decide if an item is selectable

* The decision is made in the coordinator instead by return a boolean from
  -paymentRequestSelectorViewController:didSelectItemAtIndex: indicating
  whether selection can actually be made.
* Also fixes a bug where editing an item from the selector screen, in edit
  mode, without any previosuly selected items was causing a crash.

BUG=602666

Review-Url: https://codereview.chromium.org/2956323002
Cr-Commit-Position: refs/heads/master@{#483277}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb6441a2d4301c1048836c560a3f...
==========

[commit-bot: I haz the power, 2017-06-29 03:18:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb6441a2d4301c1048836c560a3f...