ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm - Issue 2956323002: [Payment Request] Simplifies VC's logic to decide if an item is selectable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm

Issue 2956323002: [Payment Request] Simplifies VC's logic to decide if an item is selectable (Closed)

Patch Set: Addressed comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/payments/shipping_address_selection_coordinator_unittest.mm ('k') | ios/chrome/browser/ui/payments/shipping_option_selection_coordinator_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm

diff --git a/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm b/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm

index 44c1d703cd4a3233bdd8ef14f579e57153b2c7f4..d81b2af03dadd70e8be88e93403b003697b5ba7d 100644

--- a/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm

+++ b/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm

@@ -85,7 +85,7 @@ const int64_t kDelegateNotificationDelayInNanoSeconds = 0.2 * NSEC_PER_SEC;

#pragma mark - PaymentRequestSelectorViewControllerDelegate

-- (void)paymentRequestSelectorViewController:

+- (BOOL)paymentRequestSelectorViewController:

(PaymentRequestSelectorViewController*)controller

didSelectItemAtIndex:(NSUInteger)index {

// Update the data source with the selection.

@@ -94,6 +94,7 @@ const int64_t kDelegateNotificationDelayInNanoSeconds = 0.2 * NSEC_PER_SEC;

DCHECK(index < self.paymentRequest->shipping_options().size());

[self delayedNotifyDelegateOfSelection:self.paymentRequest

->shipping_options()[index]];

+ return YES;

}

- (void)paymentRequestSelectorViewControllerDidFinish: