Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2956213003: Statically allocate extension download lookups. (Closed)

Created:
3 years, 5 months ago by brettw
Modified:
3 years, 5 months ago
Reviewers:
benjhayden
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Statically allocate extension download lookups. This avoids building singleton maps to convert between strings and download enums. The maps are now pre-sorted lists of static data. Unit tests are added to ensure the data is properly sorted.

Patch Set 1 #

Patch Set 2 : Better tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -69 lines) Patch
M chrome/browser/extensions/api/downloads/downloads_api.h View 1 3 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 9 chunks +101 lines, -69 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
brettw
Better tests
3 years, 5 months ago (2017-06-28 23:51:41 UTC) #1
brettw
3 years, 5 months ago (2017-06-28 23:53:05 UTC) #4
brettw
3 years, 5 months ago (2017-06-28 23:58:17 UTC) #7
brettw
3 years, 5 months ago (2017-06-29 00:06:33 UTC) #10
Actually, I'm abandoning this, there are some constexpr problems that I think
are due to out-of-date libc++ and I've spent too much time on this (it was a
request from a comment on https://codereview.chromium.org/2829163004/).

If you like it and have the inclination, feel free to pick it up.

Powered by Google App Engine
This is Rietveld 408576698