Statically allocate extension download lookups.

chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/downloads/downloads_api.h"
 
+#include <algorithm>
+
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/download/download_core_service_factory.h"
 #include "chrome/browser/download/download_core_service_impl.h"
 #include "chrome/browser/download/download_history.h"
 #include "chrome/browser/extensions/extension_api_unittest.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/test/mock_download_manager.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 103 matching lines @@
       Profile::FromBrowserContext(browser_context));
 }
 
 // Tests that Number/double properties in query are parsed correctly.
 // Regression test for https://crbug.com/617435.
 TEST_F(DownloadsApiUnitTest, ParseSearchQuery) {
   RunFunction(new DownloadsSearchFunction, "[{\"totalBytesLess\":1}]");
   RunFunction(new DownloadsSearchFunction, "[{\"totalBytesGreater\":2}]");
 }
 
+// Marked as an "internal" unit test because it doesn't use the TEST_F macro so
+// the name must be different.
+TEST(DownloadsApiInternalUnitTest, FilterTypeSorted) {
+  struct KeyCompare {
+    bool operator()(const DownloadQueryFilterTypePair& a,
+                    const DownloadQueryFilterTypePair& b) const {
+      return strcmp(a.first, b.first) < 0;
+    }
+  };
+  EXPECT_TRUE(std::is_sorted(DownloadQueryFilterTypeBeginForTest(),
+                             DownloadQueryFilterTypeEndForTest(),
+                             KeyCompare()));
+
+  // All items should be found.
+  for (const DownloadQueryFilterTypePair* cur =
+           DownloadQueryFilterTypeBeginForTest();
+       cur != DownloadQueryFilterTypeEndForTest(); ++cur) {
+    EXPECT_EQ(cur, FindDownloadFilterTypeByString(cur->first));
+  }
+
+  EXPECT_EQ(nullptr, FindDownloadFilterTypeByString("NOTFOUND"));
+}
+
+// Marked as an "internal" unit test because it doesn't use the TEST_F macro so
+// the name must be different.
+TEST(DownloadsApiInternalUnitTest, SortTypeSorted) {
+  struct KeyCompare {
+    bool operator()(const DownloadQuerySortTypePair& a,
+                    const DownloadQuerySortTypePair& b) const {
+      return strcmp(a.first, b.first) < 0;
+    }
+  };
+  EXPECT_TRUE(std::is_sorted(DownloadQuerySortTypeBeginForTest(),
+                             DownloadQuerySortTypeEndForTest(), KeyCompare()));
+
+  // All items should be found.
+  for (const DownloadQuerySortTypePair* cur =
+           DownloadQuerySortTypeBeginForTest();
+       cur != DownloadQuerySortTypeEndForTest(); ++cur) {
+    EXPECT_EQ(cur, FindDownloadSortTypeByString(cur->first));
+  }
+
+  EXPECT_EQ(nullptr, FindDownloadSortTypeByString("NOTFOUND"));
+}
+
 }  // namespace extensions