[MD Bookmarks] Make disabled buttons in context menu do nothing when clicked.

[MD Bookmarks] Make disabled buttons in context menu do nothing when clicked.

BUG=737036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956213002
Cr-Commit-Position: refs/heads/master@{#483289}
Committed: https://chromium.googlesource.com/chromium/src/+/4ef08e4c5ad81f0f285054df0d705258178c4ede

[calamity, 2017-06-28 03:54:00]

Description was changed from

==========
[MD Bookmarks] Make disabled buttons in context menu do nothing when clicked.

BUG=737036
==========

to

==========
[MD Bookmarks] Make disabled buttons in context menu do nothing when clicked.

BUG=737036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-06-28 04:00:13]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 04:00:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-06-28 04:01:20]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2017-06-28 04:42:06]

I think this is kind of a bug with on-tap, so it could also be fixed by changing
the event handler to on-click. I'm fairly happy with either fix.

https://codereview.chromium.org/2956213002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/command_manager_test.js (right):

https://codereview.chromium.org/2956213002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/command_manager_test.js:263: var commandItem
= {};
I think this is the slightly wrong place to put this check.

In this test, prefs.canEdit == false, so the edit and delete options will be
entirely hidden, not just disabled.

The next test below tests the case you're after, where the buttons will be
disabled but not hidden.

[calamity, 2017-06-28 04:55:06]

Switched to on-click.

https://codereview.chromium.org/2956213002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/command_manager_test.js (right):

https://codereview.chromium.org/2956213002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/command_manager_test.js:263: var commandItem
= {};
On 2017/06/28 04:42:06, tsergeant wrote:
> I think this is the slightly wrong place to put this check.
> 
> In this test, prefs.canEdit == false, so the edit and delete options will be
> entirely hidden, not just disabled.
> 
> The next test below tests the case you're after, where the buttons will be
> disabled but not hidden.

Done.

[tsergeant, 2017-06-29 00:03:14]

lgtm

[calamity, 2017-06-29 02:15:51]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2017-06-29 02:16:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 04:03:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498702551841200,
"parent_rev": "55ef2f2107433cd4c6fd2515b8974e9f16bdded3", "commit_rev":
"4ef08e4c5ad81f0f285054df0d705258178c4ede"}

[commit-bot: I haz the power, 2017-06-29 04:03:41]

Description was changed from

==========
[MD Bookmarks] Make disabled buttons in context menu do nothing when clicked.

BUG=737036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Make disabled buttons in context menu do nothing when clicked.

BUG=737036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956213002
Cr-Commit-Position: refs/heads/master@{#483289}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ef08e4c5ad81f0f285054df0d70...
==========

[commit-bot: I haz the power, 2017-06-29 04:03:42]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4ef08e4c5ad81f0f285054df0d70...