Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: chrome/browser/resources/md_bookmarks/command_manager.html

Issue 2956213002: [MD Bookmarks] Make disabled buttons in context menu do nothing when clicked. (Closed)
Patch Set: use on-click Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/md_bookmarks/command_manager_test.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 2
3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
4 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html"> 4 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html">
5 <link rel="import" href="chrome://resources/html/cr/ui/command.html"> 5 <link rel="import" href="chrome://resources/html/cr/ui/command.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html">
7 <link rel="import" href="chrome://bookmarks/edit_dialog.html"> 7 <link rel="import" href="chrome://bookmarks/edit_dialog.html">
8 <link rel="import" href="chrome://bookmarks/shared_style.html"> 8 <link rel="import" href="chrome://bookmarks/shared_style.html">
9 <link rel="import" href="chrome://bookmarks/store_client.html"> 9 <link rel="import" href="chrome://bookmarks/store_client.html">
10 10
(...skipping 15 matching lines...) Expand all
26 display: none; 26 display: none;
27 } 27 }
28 </style> 28 </style>
29 <template is="cr-lazy-render" id="dropdown"> 29 <template is="cr-lazy-render" id="dropdown">
30 <dialog is="cr-action-menu" on-mousedown="onMenuMousedown_"> 30 <dialog is="cr-action-menu" on-mousedown="onMenuMousedown_">
31 <template is="dom-repeat" items="[[menuCommands_]]" as="command"> 31 <template is="dom-repeat" items="[[menuCommands_]]" as="command">
32 <button class="dropdown-item" 32 <button class="dropdown-item"
33 command$="[[command]]" 33 command$="[[command]]"
34 hidden$="[[!isCommandVisible_(command, menuIds_)]]" 34 hidden$="[[!isCommandVisible_(command, menuIds_)]]"
35 disabled$="[[!isCommandEnabled_(command, menuIds_)]]" 35 disabled$="[[!isCommandEnabled_(command, menuIds_)]]"
36 on-tap="onCommandClick_"> 36 on-click="onCommandClick_">
37 <span class="label"> 37 <span class="label">
38 [[getCommandLabel_(command, menuIds_)]] 38 [[getCommandLabel_(command, menuIds_)]]
39 </span> 39 </span>
40 <span class="sublabel"> 40 <span class="sublabel">
41 [[getCommandSublabel_(command, menuIds_)]] 41 [[getCommandSublabel_(command, menuIds_)]]
42 </span> 42 </span>
43 </button> 43 </button>
44 <hr hidden$="[[!showDividerAfter_(command, menuIds_)]]"></hr> 44 <hr hidden$="[[!showDividerAfter_(command, menuIds_)]]"></hr>
45 </template> 45 </template>
46 </dialog> 46 </dialog>
(...skipping 11 matching lines...) Expand all
58 </paper-button> 58 </paper-button>
59 <paper-button class="action-button" on-tap="onOpenConfirmTap_"> 59 <paper-button class="action-button" on-tap="onOpenConfirmTap_">
60 $i18n{openDialogConfirm} 60 $i18n{openDialogConfirm}
61 </paper-button> 61 </paper-button>
62 </div> 62 </div>
63 </dialog> 63 </dialog>
64 </template> 64 </template>
65 </template> 65 </template>
66 <script src="chrome://bookmarks/command_manager.js"></script> 66 <script src="chrome://bookmarks/command_manager.js"></script>
67 </dom-module> 67 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/webui/md_bookmarks/command_manager_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698