Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2956103002: [iOS] Add accessibility labels to Keyboard Accessory View buttons. (Closed)

Created:
3 years, 5 months ago by jif
Modified:
3 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Add accessibility labels to Keyboard Accessory View buttons. BUG=735582 Review-Url: https://codereview.chromium.org/2956103002 Cr-Commit-Position: refs/heads/master@{#482706} Committed: https://chromium.googlesource.com/chromium/src/+/1596dec56f05b622f72a94f651bbc14ecdde390d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jif
ptal
3 years, 5 months ago (2017-06-27 18:01:23 UTC) #3
justincohen
lgtm
3 years, 5 months ago (2017-06-27 18:34:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956103002/1
3 years, 5 months ago (2017-06-27 19:00:45 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 19:17:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1596dec56f05b622f72a94f651bb...

Powered by Google App Engine
This is Rietveld 408576698