Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm

Issue 2956103002: [iOS] Add accessibility labels to Keyboard Accessory View buttons. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/app/strings/ios_strings.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm
diff --git a/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm b/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm
index b4f10062505b280787224a12cc63a711d8a75cc2..a87cfa0802cb40bb4d69b794dc2d2419d67aa379 100644
--- a/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm
+++ b/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm
@@ -86,6 +86,9 @@
[voiceSearchButton addTarget:_delegate
action:@selector(keyboardAccessoryVoiceSearchTouchDown)
forControlEvents:UIControlEventTouchDown];
+ SetA11yLabelAndUiAutomationName(voiceSearchButton,
+ IDS_IOS_KEYBOARD_ACCESSORY_VIEW_VOICE_SEARCH,
+ @"Voice Search");
[voiceSearchButton
addTarget:_delegate
action:@selector(keyboardAccessoryVoiceSearchTouchUpInside)
@@ -94,6 +97,9 @@
[cameraButton addTarget:_delegate
action:@selector(keyboardAccessoryCameraSearchTouchUpInside)
forControlEvents:UIControlEventTouchUpInside];
+ SetA11yLabelAndUiAutomationName(
+ cameraButton, IDS_IOS_KEYBOARD_ACCESSORY_VIEW_QR_CODE_SEARCH,
+ @"QR code Search");
// Create and add a stackview containing containing the buttons for voice
// search and camera search.
« no previous file with comments | « ios/chrome/app/strings/ios_strings.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698