Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2955973007: Revert of Made surrounding text work for last word in a document (Closed)

Created:
3 years, 5 months ago by benwells
Modified:
3 years, 5 months ago
CC:
blink-reviews, chromium-reviews, Donn Denman, Theresa
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Made surrounding text work for last word in a document (patchset #5 id:80001 of https://codereview.chromium.org/2928073002/ ) Reason for revert: This has caused the surrounding-text.html layout test to start failing on some bots. See for example: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/28157 Original issue's description: > Made surrounding text work for last word in a document > > The surrounding text algorithm did not proceed if the range > between the end of selection and the end of document had zero > length. Current CL removes this restriction. > > BUG= > > Review-Url: https://codereview.chromium.org/2928073002 > Cr-Commit-Position: refs/heads/master@{#482719} > Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b3906dfcd6661 TBR=yosin@chromium.org,amaralp@chromium.org,timav@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2955973007 Cr-Commit-Position: refs/heads/master@{#482839} Committed: https://chromium.googlesource.com/chromium/src/+/95e377e8e0851d2d5fa089036b0e24a1a75f89c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/editing/surrounding-text/surrounding-text.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/surrounding-text/surrounding-text-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.cpp View 2 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingTextTest.cpp View 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
benwells
Created Revert of Made surrounding text work for last word in a document
3 years, 5 months ago (2017-06-28 01:16:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955973007/1
3 years, 5 months ago (2017-06-28 01:16:47 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 01:17:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95e377e8e0851d2d5fa089036b0e...

Powered by Google App Engine
This is Rietveld 408576698