Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2928073002:
Reland: Made surrounding text work for last word in a document (Closed)
|
Created:
3 years, 6 months ago by Tima Vaisburd Modified:
3 years, 5 months ago CC:
blink-reviews, chromium-reviews, Donn Denman, Theresa Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland: Made surrounding text work for last word in a document
The surrounding text algorithm did not proceed if the range
between the end of selection and the end of document had zero
length. Current CL removes this restriction.
The reason for the old behavior seems to be that selection within
control elements should not produce surrounding text. Checked for
HTMLFormControlElement::EnclosingFormControlElement() explicitly.
BUG=724215
Review-Url: https://codereview.chromium.org/2928073002
Cr-Original-Commit-Position: refs/heads/master@{#482719}
Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b3906dfcd6661
Review-Url: https://codereview.chromium.org/2928073002
Cr-Commit-Position: refs/heads/master@{#482881}
Committed: https://chromium.googlesource.com/chromium/src/+/72820cdb1298dc9e5c6519b1e62048345cde7644
Patch Set 1 #Patch Set 2 : Fixing LayoutTests #Patch Set 3 : Rebased #Patch Set 4 : An attempt to fix layout test #Patch Set 5 : Changed expectations #Patch Set 6 : Do not create surrounding text for control elements, updated layout tests #
Messages
Total messages: 53 (45 generated)
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Made surrounding text work for last word in document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. BUG= ========== to ========== Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. BUG= ==========
timav@chromium.org changed reviewers: + amaralp@chromium.org, yosin@chromium.org
We do not retrieve surrounding text if the forward_range has zero length, this looks like a bug to me. PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2017/06/09 02:28:01, yosin_UTC9 wrote: > lgtm Hm, not sure what is different on mac platform.
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by timav@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2928073002/#ps80001 (title: "Changed expectations")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498590044035080,
"parent_rev": "7a5ff008cb7963c34c5207fa60145a1d7d9ea99a", "commit_rev":
"445e7e4dc4bb49245a40b102bf3b3906dfcd6661"}
Message was sent while issue was closed.
Description was changed from ========== Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. BUG= ========== to ========== Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. BUG= Review-Url: https://codereview.chromium.org/2928073002 Cr-Commit-Position: refs/heads/master@{#482719} Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b...
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2955973007/ by benwells@chromium.org. The reason for reverting is: This has caused the surrounding-text.html layout test to start failing on some bots. See for example: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu....
Message was sent while issue was closed.
Description was changed from ========== Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. BUG= Review-Url: https://codereview.chromium.org/2928073002 Cr-Commit-Position: refs/heads/master@{#482719} Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b... ========== to ========== Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. BUG=724215 Review-Url: https://codereview.chromium.org/2928073002 Cr-Commit-Position: refs/heads/master@{#482719} Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b... ==========
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. BUG=724215 Review-Url: https://codereview.chromium.org/2928073002 Cr-Commit-Position: refs/heads/master@{#482719} Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b... ========== to ========== Reland: Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. The reason for the old behavior seems to be that selection within control elements should not produce surrounding text. Checked for HTMLFormControlElement::EnclosingFormControlElement() explicitly. BUG=724215 Review-Url: https://codereview.chromium.org/2928073002 Cr-Commit-Position: refs/heads/master@{#482719} Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was unchecked by timav@chromium.org
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by timav@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2928073002/#ps100001 (title: "Do not create surrounding text for control elements, updated layout tests")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498624463990650,
"parent_rev": "3fadc6c1ca09861ec2e100cc4fe9354074645a4f", "commit_rev":
"72820cdb1298dc9e5c6519b1e62048345cde7644"}
Message was sent while issue was closed.
Description was changed from ========== Reland: Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. The reason for the old behavior seems to be that selection within control elements should not produce surrounding text. Checked for HTMLFormControlElement::EnclosingFormControlElement() explicitly. BUG=724215 Review-Url: https://codereview.chromium.org/2928073002 Cr-Commit-Position: refs/heads/master@{#482719} Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b... ========== to ========== Reland: Made surrounding text work for last word in a document The surrounding text algorithm did not proceed if the range between the end of selection and the end of document had zero length. Current CL removes this restriction. The reason for the old behavior seems to be that selection within control elements should not produce surrounding text. Checked for HTMLFormControlElement::EnclosingFormControlElement() explicitly. BUG=724215 Review-Url: https://codereview.chromium.org/2928073002 Cr-Original-Commit-Position: refs/heads/master@{#482719} Committed: https://chromium.googlesource.com/chromium/src/+/445e7e4dc4bb49245a40b102bf3b... Review-Url: https://codereview.chromium.org/2928073002 Cr-Commit-Position: refs/heads/master@{#482881} Committed: https://chromium.googlesource.com/chromium/src/+/72820cdb1298dc9e5c6519b1e620... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/72820cdb1298dc9e5c6519b1e620... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
