third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T13:57:23 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index b3a5d0f7ef2ee9c0c6719d253fd41fe719e675f6..5d6f8c884035865639dd5617b70bf4788feb49c6 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -384,7 +384,7 @@ bool InsertListCommand::DoApplyForSingleParagraph(

GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();

Node* first_child_in_list =

- EnclosingListChild(VisiblePosition::FirstPositionInNode(list_element)

+ EnclosingListChild(VisiblePosition::FirstPositionInNode(*list_element)

.DeepEquivalent()

.AnchorNode(),

list_element);

@@ -394,7 +394,7 @@ bool InsertListCommand::DoApplyForSingleParagraph(

: list_element;

MoveParagraphWithClones(

- VisiblePosition::FirstPositionInNode(list_element),

+ VisiblePosition::FirstPositionInNode(*list_element),

VisiblePosition::LastPositionInNode(list_element), new_list,

outer_block, editing_state);

if (editing_state->IsAborted())

@@ -460,7 +460,7 @@ void InsertListCommand::UnlistifyParagraph(

VisiblePosition end;

DCHECK(list_child_node);

if (isHTMLLIElement(*list_child_node)) {

- start = VisiblePosition::FirstPositionInNode(list_child_node);

+ start = VisiblePosition::FirstPositionInNode(*list_child_node);

end = VisiblePosition::LastPositionInNode(list_child_node);

next_list_child = list_child_node->nextSibling();

previous_list_child = list_child_node->previousSibling();