third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp - Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T13:57:23 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

index 7bd2a581cf3f34c3488fb3a069bfae1ebf363356..dda03865f00eabbec295fdab1a6c738f6752f45a 100644

--- a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

@@ -227,7 +227,7 @@ void IndentOutdentCommand::OutdentParagraph(EditingState* editing_state) {

// The selection is inside a blockquote i.e. enclosingNode is a blockquote

VisiblePosition position_in_enclosing_block =

- VisiblePosition::FirstPositionInNode(enclosing_element);

+ VisiblePosition::FirstPositionInNode(*enclosing_element);

// If the blockquote is inline, the start of the enclosing block coincides

// with positionInEnclosingBlock.

VisiblePosition start_of_enclosing_block =