third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T13:57:23 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index 56ff069d4dc3269c984b5517e04accd9665028c2..3c41955a657bdebf39d92e473099df1f6290cec1 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -1067,7 +1067,7 @@ HTMLElement* CompositeEditCommand::MoveParagraphContentsToNewBlockIfNecessary(

visible_paragraph_start = StartOfParagraph(visible_pos);

visible_paragraph_end = EndOfParagraph(visible_pos);

MoveParagraphs(visible_paragraph_start, visible_paragraph_end,

- VisiblePosition::FirstPositionInNode(new_block),

+ VisiblePosition::FirstPositionInNode(*new_block),

tkent 2017/06/26 08:08:22 Is new_block always non-null?

yosin_UTC9 2017/06/26 08:53:52 Yes, |new_block| holds return value of InsertNewDe

editing_state);

if (editing_state->IsAborted())

return nullptr;

@@ -1798,7 +1798,7 @@ Position CompositeEditCommand::PositionAvoidingSpecialElementBoundary(

// wrong paragraph.

if (enclosing_anchor && !IsEnclosingBlock(enclosing_anchor)) {

VisiblePosition first_in_anchor =

- VisiblePosition::FirstPositionInNode(enclosing_anchor);

+ VisiblePosition::FirstPositionInNode(*enclosing_anchor);

VisiblePosition last_in_anchor =

VisiblePosition::LastPositionInNode(enclosing_anchor);

// If visually just after the anchor, insert *inside* the anchor unless it's

@@ -1882,7 +1882,7 @@ Node* CompositeEditCommand::SplitTreeToNode(Node* start,

// Do not split a node when doing so introduces an empty node.

VisiblePosition position_in_parent =

- VisiblePosition::FirstPositionInNode(parent_element);

+ VisiblePosition::FirstPositionInNode(*parent_element);

VisiblePosition position_in_node =

CreateVisiblePosition(FirstPositionInOrBeforeNode(node));

if (position_in_parent.DeepEquivalent() !=