Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2955813002:
viz: Replace a DCHECK with proper error handling. (Closed)
Descriptionviz: Replace a DCHECK with proper error handling.
The code processes input from untrusted clients (e.g. renderers). So
instead of enforcing valid input through DCHECK(), properly handle
unsupported input and return invalid memory handles.
BUG=733482
Review-Url: https://codereview.chromium.org/2955813002
Cr-Commit-Position: refs/heads/master@{#482425}
Committed: https://chromium.googlesource.com/chromium/src/+/1e7ac4345c9b98f7a32115809a64f7e86bee33e6
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : . #
Messages
Total messages: 24 (18 generated)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== viz: Replace a DCHECK with proper error handling. The code processes input from untrusted clients (e.g. renderers). So instead of enforcing valid input through DCHECK(), properly handle unsupported input and return invalid memory handles. BUG=... ========== to ========== viz: Replace a DCHECK with proper error handling. The code processes input from untrusted clients (e.g. renderers). So instead of enforcing valid input through DCHECK(), properly handle unsupported input and return invalid memory handles. BUG=733482 ==========
sadrul@chromium.org changed reviewers: + reveman@chromium.org
Thanks for the test. Lgtm.
danakj@chromium.org changed reviewers: + danakj@chromium.org
driveby LGTM https://codereview.chromium.org/2955813002/diff/20001/components/viz/common/s... File components/viz/common/server_gpu_memory_buffer_manager_unittest.cc (right): https://codereview.chromium.org/2955813002/diff/20001/components/viz/common/s... components/viz/common/server_gpu_memory_buffer_manager_unittest.cc:253: } Can you add something that shows we actually hit both branches? Else this test could in the future break in some way and only hit one branch and we'd never know.
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2955813002/diff/20001/components/viz/common/s... File components/viz/common/server_gpu_memory_buffer_manager_unittest.cc (right): https://codereview.chromium.org/2955813002/diff/20001/components/viz/common/s... components/viz/common/server_gpu_memory_buffer_manager_unittest.cc:253: } On 2017/06/26 15:43:42, danakj wrote: > Can you add something that shows we actually hit both branches? Else this test > could in the future break in some way and only hit one branch and we'd never > know. Good point. Done.
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org, reveman@chromium.org Link to the patchset: https://codereview.chromium.org/2955813002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498513752729310,
"parent_rev": "b5cae6d3aaf71d0f6186504da2f50fef77d20982", "commit_rev":
"288a75d729dc255b21f6de12572331f8ed3362c3"}
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498513752729310,
"parent_rev": "4d09478c03cfc9c735b46af22aad84589e23911b", "commit_rev":
"1e7ac4345c9b98f7a32115809a64f7e86bee33e6"}
Message was sent while issue was closed.
Description was changed from ========== viz: Replace a DCHECK with proper error handling. The code processes input from untrusted clients (e.g. renderers). So instead of enforcing valid input through DCHECK(), properly handle unsupported input and return invalid memory handles. BUG=733482 ========== to ========== viz: Replace a DCHECK with proper error handling. The code processes input from untrusted clients (e.g. renderers). So instead of enforcing valid input through DCHECK(), properly handle unsupported input and return invalid memory handles. BUG=733482 Review-Url: https://codereview.chromium.org/2955813002 Cr-Commit-Position: refs/heads/master@{#482425} Committed: https://chromium.googlesource.com/chromium/src/+/1e7ac4345c9b98f7a32115809a64... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1e7ac4345c9b98f7a32115809a64... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
