viz: Replace a DCHECK with proper error handling.

components/viz/common/server_gpu_memory_buffer_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/viz/common/server_gpu_memory_buffer_manager.h"
 
 #include "base/logging.h"
 #include "base/threading/sequenced_task_runner_handle.h"
 #include "gpu/ipc/client/gpu_memory_buffer_impl.h"
 #include "gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h"
@@ skipping 29 matching lines @@
       pending_buffers_.insert(client_id);
       gpu_service_->CreateGpuMemoryBuffer(
           id, size, format, usage, client_id, surface_handle,
           base::Bind(&ServerGpuMemoryBufferManager::OnGpuMemoryBufferAllocated,
                      weak_factory_.GetWeakPtr(), client_id,
                      base::Passed(std::move(callback))));
       return;
     }
   }
 
-  DCHECK(gpu::GpuMemoryBufferImplSharedMemory::IsUsageSupported(usage))
-      << static_cast<int>(usage);
-  task_runner_->PostTask(
-      FROM_HERE,
-      base::BindOnce(
-          std::move(callback),
-          gpu::GpuMemoryBufferImplSharedMemory::CreateGpuMemoryBuffer(id, size,
-                                                                      format)));
+  gfx::GpuMemoryBufferHandle buffer_handle;
+  // The requests are coming in from untrusted clients. So verify that it is
+  // possible to allocate shared memory buffer first.
+  if (gpu::GpuMemoryBufferImplSharedMemory::IsUsageSupported(usage) &&
+      gpu::GpuMemoryBufferImplSharedMemory::IsSizeValidForFormat(size,
+                                                                 format)) {
+    buffer_handle = gpu::GpuMemoryBufferImplSharedMemory::CreateGpuMemoryBuffer(
+        id, size, format);
+  }
+
+  task_runner_->PostTask(FROM_HERE,
+                         base::BindOnce(std::move(callback), buffer_handle));
 }
 
 std::unique_ptr<gfx::GpuMemoryBuffer>
 ServerGpuMemoryBufferManager::CreateGpuMemoryBuffer(
     const gfx::Size& size,
     gfx::BufferFormat format,
     gfx::BufferUsage usage,
     gpu::SurfaceHandle surface_handle) {
   gfx::GpuMemoryBufferId id(next_gpu_memory_id_++);
   gfx::GpuMemoryBufferHandle handle;
@@ skipping 63 matching lines @@
     }
     std::move(callback).Run(gfx::GpuMemoryBufferHandle());
     return;
   }
   if (!handle.is_null())
     native_buffers_[client_id].insert(handle.id);
   std::move(callback).Run(handle);
 }
 
 }  // namespace viz