Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2955793002: Revert of Make some functions that are hit during renderer startup available for inlining (Closed)

Created:
3 years, 5 months ago by Michael Achenbach
Modified:
3 years, 5 months ago
CC:
Hannes Payer (out of office), marja+watch_chromium.org, v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make some functions that are hit during renderer startup available for inlining (patchset #3 id:40001 of https://codereview.chromium.org/2950993002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2954833002/ E.g.: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/449680 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/324953 Please include those chromium trybots on reland. Maybe missing symbol export? Original issue's description: > Make some functions that are hit during renderer startup available for inlining > > This is towards closing the perf gap between the MSVC build (which uses link- > time optimization) and Clang (where LTO isn't ready on Windows yet). We did > a study (see bug) to see which non-inlined functions are hit a lot during render > start-up, and which would be inlined during LTO. This should benefit performance > in all builds which currently don't use LTO (Android, Linux, Mac) as well as > the Win/Clang build. > > The binary size of chrome_child.dll increases by 2KB with this. > > BUG=chromium:728324 > > Review-Url: https://codereview.chromium.org/2950993002 > Cr-Commit-Position: refs/heads/master@{#46191} > Committed: https://chromium.googlesource.com/v8/v8/+/d00d52be1fce9c1bf5558c8b26bf984efd09e65b TBR=jochen@chromium.org,mstarzinger@chromium.org,rmcilroy@chromium.org,vogelheim@chromium.org,marja@chromium.org,mlippautz@chromium.org,thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:728324 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2955793002 Cr-Commit-Position: refs/heads/master@{#46195} Committed: https://chromium.googlesource.com/v8/v8/+/410a753ba2b0795e9d9b309c3a11ee5af6ab7b87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -291 lines) Patch
M src/ast/ast.h View 1 chunk +1 line, -11 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ast/scopes.h View 2 chunks +2 lines, -13 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/ast/variables.h View 1 chunk +1 line, -18 lines 0 comments Download
M src/ast/variables.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +199 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -198 lines 0 comments Download
M src/heap/scavenger.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/scavenger.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/heap/scavenger-inl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +2 lines, -12 lines 0 comments Download
M src/interpreter/bytecodes.cc View 2 chunks +25 lines, -12 lines 0 comments Download
M src/parsing/scanner.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/parsing/scanner.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/snapshot/snapshot-source-sink.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/snapshot/snapshot-source-sink.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
Created Revert of Make some functions that are hit during renderer startup available for inlining
3 years, 5 months ago (2017-06-25 20:29:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955793002/1
3 years, 5 months ago (2017-06-25 20:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955793002/1
3 years, 5 months ago (2017-06-25 20:34:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/410a753ba2b0795e9d9b309c3a11ee5af6ab7b87
3 years, 5 months ago (2017-06-25 20:34:48 UTC) #10
hans
3 years, 5 months ago (2017-06-26 15:46:02 UTC) #11
Message was sent while issue was closed.
Sorry for the breakage. Yes, the fix is simple; it's was a missing export:
https://codereview.chromium.org/2954353002/

Powered by Google App Engine
This is Rietveld 408576698