Filter QUIC alternative service if the versions advertised by the server

Filter QUIC alternative service if the versions advertised by the server
is not supported by the netstack

BUG=736063
Review-Url: https://codereview.chromium.org/2955673002
Cr-Commit-Position: refs/heads/master@{#482363}
Committed: https://chromium.googlesource.com/chromium/src/+/8ac630d0f36a306d48d19e8ef2bf7292d6fb55cc

[Zhongyi Shi, 2017-06-23 21:27:50]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 21:28:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-06-23 21:28:32]

zhongyi@chromium.org changed reviewers:
+ bnc@chromium.org

[Zhongyi Shi, 2017-06-23 21:28:33]

bnc@: PTAL, thanks!

[commit-bot: I haz the power, 2017-06-23 22:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 22:52:04]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-06-26 15:44:53]

LGTM with nits, thank you.

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
File net/spdy/chromium/spdy_session.cc (right):

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
net/spdy/chromium/spdy_session.cc:3026: // coull use the the same function.
s/coull/could/

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
File net/spdy/chromium/spdy_session_unittest.cc (right):

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
net/spdy/chromium/spdy_session_unittest.cc:5660: // Regression test for
crbug.com/736063.
Optional: https://crbug.com/736063.  Because https everywhere!, also because
some tools that developers might use (like vim in gnome-terminal) would not
parse it as a clickable link without the https:// prefix.

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
net/spdy/chromium/spdy_session_unittest.cc:5669: // Fix the parse function and
change the hardcode invliad version to
s/invliad/invalid/

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
net/spdy/chromium/spdy_session_unittest.cc:5669: // Fix the parse function and
change the hardcode invliad version to
Optional: s/hardcode/hardcoded/, if I understand the context correctly.

[Zhongyi Shi, 2017-06-26 17:29:19]

Thanks for the review, Bence. Comments addressed, landing now.

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
File net/spdy/chromium/spdy_session.cc (right):

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
net/spdy/chromium/spdy_session.cc:3026: // coull use the the same function.
On 2017/06/26 15:44:53, Bence wrote:
> s/coull/could/

Done.

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
File net/spdy/chromium/spdy_session_unittest.cc (right):

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
net/spdy/chromium/spdy_session_unittest.cc:5660: // Regression test for
crbug.com/736063.
On 2017/06/26 15:44:53, Bence wrote:
> Optional: https://crbug.com/736063.  Because https everywhere!, also because
> some tools that developers might use (like vim in gnome-terminal) would not
> parse it as a clickable link without the https:// prefix.

Done. Good point!

https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
net/spdy/chromium/spdy_session_unittest.cc:5669: // Fix the parse function and
change the hardcode invliad version to
On 2017/06/26 15:44:53, Bence wrote:
> Optional: s/hardcode/hardcoded/, if I understand the context correctly.

Done.

[Zhongyi Shi, 2017-06-26 17:29:23]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-06-26 17:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2955673002/#ps40001
(title: "address comments #7")

[commit-bot: I haz the power, 2017-06-26 17:29:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-06-26 19:32:28]

On 2017/06/26 17:29:19, Zhongyi Shi wrote:
> Thanks for the review, Bence. Comments addressed, landing now.
> 
>
https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
> File net/spdy/chromium/spdy_session.cc (right):
> 
>
https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
> net/spdy/chromium/spdy_session.cc:3026: // coull use the the same function.
> On 2017/06/26 15:44:53, Bence wrote:
> > s/coull/could/
> 
> Done.
> 
>
https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
> File net/spdy/chromium/spdy_session_unittest.cc (right):
> 
>
https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
> net/spdy/chromium/spdy_session_unittest.cc:5660: // Regression test for
> crbug.com/736063.
> On 2017/06/26 15:44:53, Bence wrote:
> > Optional: https://crbug.com/736063.  Because https everywhere!, also because
> > some tools that developers might use (like vim in gnome-terminal) would not
> > parse it as a clickable link without the https:// prefix.
> 
> Done. Good point!
> 
>
https://codereview.chromium.org/2955673002/diff/20001/net/spdy/chromium/spdy_...
> net/spdy/chromium/spdy_session_unittest.cc:5669: // Fix the parse function and
> change the hardcode invliad version to
> On 2017/06/26 15:44:53, Bence wrote:
> > Optional: s/hardcode/hardcoded/, if I understand the context correctly.
> 
> Done.

LGTM, thank you!

[commit-bot: I haz the power, 2017-06-26 19:46:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498498163457080,
"parent_rev": "a2849be12be0a4b84f45dc9185019f93b1c317b4", "commit_rev":
"8ac630d0f36a306d48d19e8ef2bf7292d6fb55cc"}

[commit-bot: I haz the power, 2017-06-26 19:46:51]

Description was changed from

==========
Filter QUIC alternative service if the versions advertised by the server
is not supported by the netstack

BUG=736063
==========

to

==========
Filter QUIC alternative service if the versions advertised by the server
is not supported by the netstack

BUG=736063

Review-Url: https://codereview.chromium.org/2955673002
Cr-Commit-Position: refs/heads/master@{#482363}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ac630d0f36a306d48d19e8ef2bf...
==========

[commit-bot: I haz the power, 2017-06-26 19:46:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8ac630d0f36a306d48d19e8ef2bf...