Filter QUIC alternative service if the versions advertised by the server

net/spdy/chromium/spdy_session_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/chromium/spdy_session.h"
 
 #include <algorithm>
 #include <memory>
 #include <utility>
 
@@ skipping 5639 matching lines @@
 
   altsvc_info_vector =
       spdy_session_pool_->http_server_properties()->GetAlternativeServiceInfos(
           url::SchemeHostPort(GURL(origin)));
   ASSERT_EQ(1u, altsvc_info_vector.size());
   AlternativeService alternative_service(kProtoQUIC, "alternative.example.org",
                                          443u);
   EXPECT_EQ(alternative_service, altsvc_info_vector[0].alternative_service());
 }
 
+// Regression test for crbug.com/736063.

[Bence, 2017/06/26 15:44:53]

Optional: https://crbug.com/736063.  Because https everywhere!, also because
some tools that developers might use (like vim in gnome-terminal) would not
parse it as a clickable link without the https:// prefix.

[Zhongyi Shi, 2017/06/26 17:29:18]

Done. Good point!

+TEST_F(AltSvcFrameTest, IgnoreQuicAltSvcWithUnsupportedVersion) {
+  const char origin[] = "https://mail.example.org";
+  SpdyAltSvcIR altsvc_ir(/* stream_id = */ 0);
+  SpdyAltSvcWireFormat::AlternativeService quic_alternative_service(
+      "quic", "alternative.example.org", 443, 86400,
+      SpdyAltSvcWireFormat::VersionVector());
+  // TODO(zhongyi): SpdyAltSvcWireFormat::ParseHeaderFieldValue expects positve
+  // versions while VersionVector allows nonnegative verisons.
+  // Fix the parse function and change the hardcode invliad version to

[Bence, 2017/06/26 15:44:53]

Optional: s/hardcode/hardcoded/, if I understand the context correctly.

[Bence, 2017/06/26 15:44:53]

s/invliad/invalid/

[Zhongyi Shi, 2017/06/26 17:29:19]

Done.

+  // QUIC_VERSION_UNSUPPORTED.
+  quic_alternative_service.version.push_back(/* invalid QUIC version */ 1);
+  altsvc_ir.add_altsvc(quic_alternative_service);
+  altsvc_ir.set_origin(origin);
+  AddSocketData(altsvc_ir);
+  AddSSLSocketData();
+
+  CreateNetworkSession();
+  CreateSecureSpdySession();
+
+  base::RunLoop().RunUntilIdle();
+
+  const url::SchemeHostPort session_origin("https", test_url_.host(),
+                                           test_url_.EffectiveIntPort());
+  AlternativeServiceInfoVector altsvc_info_vector =
+      spdy_session_pool_->http_server_properties()->GetAlternativeServiceInfos(
+          session_origin);
+  ASSERT_TRUE(altsvc_info_vector.empty());
+
+  altsvc_info_vector =
+      spdy_session_pool_->http_server_properties()->GetAlternativeServiceInfos(
+          url::SchemeHostPort(GURL(origin)));
+  ASSERT_EQ(0u, altsvc_info_vector.size());
+}
+
 TEST_F(AltSvcFrameTest, DoNotProcessAltSvcFrameOnInsecureSession) {
   const char origin[] = "https://mail.example.org";
   SpdyAltSvcIR altsvc_ir(/* stream_id = */ 0);
   altsvc_ir.add_altsvc(alternative_service_);
   altsvc_ir.set_origin(origin);
   AddSocketData(altsvc_ir);
   AddSSLSocketData();
 
   CreateNetworkSession();
   CreateInsecureSpdySession();
@@ skipping 476 matching lines @@
   ssl_info.cert = ImportCertFromFile(GetTestCertsDirectory(),
                                      "spdy_pooling.pem");
   ssl_info.is_issued_by_known_root = true;
   ssl_info.public_key_hashes.push_back(test::GetTestHashValue(primary_pin));
 
   EXPECT_TRUE(SpdySession::CanPool(
       &tss, ssl_info, "www.example.org", "mail.example.org"));
 }
 
 }  // namespace net