Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2955643002: clang/win: Enable -Wmicrosoft-enum-forward-reference (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 5 months ago
CC:
chromium-reviews, brucedawson
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable -Wmicrosoft-enum-forward-reference BUG=718880 TBR=sergeyu Review-Url: https://codereview.chromium.org/2955643002 Cr-Commit-Position: refs/heads/master@{#482112} Committed: https://chromium.googlesource.com/chromium/src/+/2a02c1af6db275a166952455d03bdffa7e0bfbf6

Patch Set 1 #

Patch Set 2 : remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/win/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Nico
hans: build/ sergeyu: remoting/
3 years, 6 months ago (2017-06-23 21:19:08 UTC) #10
hans
lgtm
3 years, 6 months ago (2017-06-23 21:27:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955643002/20001
3 years, 6 months ago (2017-06-24 01:47:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2a02c1af6db275a166952455d03bdffa7e0bfbf6
3 years, 6 months ago (2017-06-24 01:52:49 UTC) #19
Do not use (sergeyu)
3 years, 5 months ago (2017-06-27 04:59:08 UTC) #21
Message was sent while issue was closed.
remoting lgtm

Powered by Google App Engine
This is Rietveld 408576698