Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2955643002: clang/win: Enable -Wmicrosoft-enum-forward-reference (Closed)
Patch Set: remove Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/host/win/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 cflags += [ "/wd4702" ] # Unreachable code. 1068 cflags += [ "/wd4702" ] # Unreachable code.
1069 } 1069 }
1070 1070
1071 # Building with Clang on Windows is a work in progress and very 1071 # Building with Clang on Windows is a work in progress and very
1072 # experimental. See crbug.com/82385. 1072 # experimental. See crbug.com/82385.
1073 if (is_clang) { 1073 if (is_clang) {
1074 cflags += [ 1074 cflags += [
1075 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 1075 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
1076 "-Wno-unknown-pragmas", # http://crbug.com/505314 1076 "-Wno-unknown-pragmas", # http://crbug.com/505314
1077 "-Wno-microsoft-cast", # http://crbug.com/550065 1077 "-Wno-microsoft-cast", # http://crbug.com/550065
1078 "-Wno-microsoft-enum-forward-reference", # http://crbug.com/718880
1079 ] 1078 ]
1080 } 1079 }
1081 } else { 1080 } else {
1082 if (is_mac && !is_nacl) { 1081 if (is_mac && !is_nacl) {
1083 # When compiling Objective-C, warns if a method is used whose 1082 # When compiling Objective-C, warns if a method is used whose
1084 # availability is newer than the deployment target. This is not 1083 # availability is newer than the deployment target. This is not
1085 # required when compiling Chrome for iOS. 1084 # required when compiling Chrome for iOS.
1086 cflags += [ "-Wpartial-availability" ] 1085 cflags += [ "-Wpartial-availability" ]
1087 } 1086 }
1088 1087
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
1807 1806
1808 if (is_ios || is_mac) { 1807 if (is_ios || is_mac) {
1809 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1808 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1810 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1809 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1811 config("enable_arc") { 1810 config("enable_arc") {
1812 common_flags = [ "-fobjc-arc" ] 1811 common_flags = [ "-fobjc-arc" ]
1813 cflags_objc = common_flags 1812 cflags_objc = common_flags
1814 cflags_objcc = common_flags 1813 cflags_objcc = common_flags
1815 } 1814 }
1816 } 1815 }
OLDNEW
« no previous file with comments | « no previous file | remoting/host/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698