Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 2955623002: Provide link start and end speech output (Closed)

Created:
3 years, 6 months ago by David Tseng
Modified:
3 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, aleventhal+watch_chromium.org, je_julie, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide link start and end speech output BUG=719654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2955623002 Cr-Commit-Position: refs/heads/master@{#482073} Committed: https://chromium.googlesource.com/chromium/src/+/47a02996a6e9acfd97e862df6732eeb78095d469

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 1 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
David Tseng
3 years, 6 months ago (2017-06-23 17:51:23 UTC) #4
dmazzoni
lgtm
3 years, 6 months ago (2017-06-23 18:33:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955623002/40001
3 years, 6 months ago (2017-06-23 22:34:44 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 23:45:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/47a02996a6e9acfd97e862df6732...

Powered by Google App Engine
This is Rietveld 408576698