components/security_interstitials/core/safe_browsing_loud_error_ui.h - Issue 2955503002: Make interstitial links open in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/safe_browsing_loud_error_ui.h

Issue 2955503002: Make interstitial links open in a new tab (Closed)

Patch Set: Rebase CL Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/security_interstitials/core/controller_client.h ('K') | « components/security_interstitials/core/controller_client.cc ('k') | components/security_interstitials/core/safe_browsing_loud_error_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/safe_browsing_loud_error_ui.h

diff --git a/components/security_interstitials/core/safe_browsing_loud_error_ui.h b/components/security_interstitials/core/safe_browsing_loud_error_ui.h

index d5a1e6a4c3567039bd6a50294e84059f92793b2e..23857f2e97c3dc0f201abfec244f8b7db422375a 100644

--- a/components/security_interstitials/core/safe_browsing_loud_error_ui.h

+++ b/components/security_interstitials/core/safe_browsing_loud_error_ui.h

@@ -48,6 +48,8 @@ class SafeBrowsingLoudErrorUI

void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data);

void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);

+ GURL learn_more_test_url_;

meacer 2017/06/23 20:28:32 It seems like this variable isn't used (you have l

sperigo 2017/06/23 21:32:12 Oops!

sperigo 2017/06/23 21:32:12 Done.

DISALLOW_COPY_AND_ASSIGN(SafeBrowsingLoudErrorUI);

};