Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2010)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/security_interstitials/core/controller_client.h

Issue 2955503002: Make interstitial links open in a new tab (Closed)
Patch Set: Rebase CL Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/security_interstitials/content/security_interstitial_controller_client.cc ('K') | « components/security_interstitials/content/security_interstitial_page.cc ('k') | components/security_interstitials/core/controller_client.cc » ('j') | components/security_interstitials/core/safe_browsing_loud_error_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/security_interstitials/core/controller_client.h
diff --git a/components/security_interstitials/core/controller_client.h b/components/security_interstitials/core/controller_client.h
index 613c6bc9f7f6c53cf0c9911e66ae3f6ae4df361f..2f246e4876f26b416870c9a1d185dfa723054ed6 100644
--- a/components/security_interstitials/core/controller_client.h
+++ b/components/security_interstitials/core/controller_client.h
@@ -87,12 +87,18 @@ class ControllerClient {
MetricsHelper* metrics_helper() const;
+ virtual void OpenUrlInNewForegroundTab(const GURL& url) = 0;
+
virtual void OpenUrlInCurrentTab(const GURL& url) = 0;
virtual PrefService* GetPrefService() = 0;
virtual const std::string& GetApplicationLocale() const = 0;
+ virtual GURL GetHelpCenterUrl() const = 0;
+
+ virtual void SetHelpCenterUrlForTesting(const GURL test_url) = 0;
meacer 2017/06/23 20:28:32 const GURL&
sperigo 2017/06/23 21:32:12 Done.
+
protected:
virtual const std::string GetExtendedReportingPrefName() const = 0;
« components/security_interstitials/content/security_interstitial_controller_client.cc ('K') | « components/security_interstitials/content/security_interstitial_page.cc ('k') | components/security_interstitials/core/controller_client.cc » ('j') | components/security_interstitials/core/safe_browsing_loud_error_ui.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698