components/security_interstitials/core/safe_browsing_loud_error_ui.h - Issue 2955503002: Make interstitial links open in a new tab

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/security_interstitials/core/safe_browsing_loud_error_ui.h

Issue 2955503002: Make interstitial links open in a new tab (Closed)

Patch Set: Rebase CL Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/security_interstitials/core/controller_client.h ('K') | « components/security_interstitials/core/controller_client.cc ('k') | components/security_interstitials/core/safe_browsing_loud_error_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_SECURITY_INTERSTITIALS_CORE_SAFE_BROWSING_LOUD_ERROR_UI_H_	5 #ifndef COMPONENTS_SECURITY_INTERSTITIALS_CORE_SAFE_BROWSING_LOUD_ERROR_UI_H_

6 #define COMPONENTS_SECURITY_INTERSTITIALS_CORE_SAFE_BROWSING_LOUD_ERROR_UI_H_	6 #define COMPONENTS_SECURITY_INTERSTITIALS_CORE_SAFE_BROWSING_LOUD_ERROR_UI_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/time/time.h"	9 #include "base/time/time.h"

10 #include "base/values.h"	10 #include "base/values.h"

(...skipping 30 matching lines...) Expand all Loading...
41 int GetHTMLTemplateId() const override;	41 int GetHTMLTemplateId() const override;

42	42

43 private:	43 private:

44 // Fills the passed dictionary with the values to be passed to the template	44 // Fills the passed dictionary with the values to be passed to the template

45 // when creating the HTML.	45 // when creating the HTML.

46 void PopulateExtendedReportingOption(base::DictionaryValue* load_time_data);	46 void PopulateExtendedReportingOption(base::DictionaryValue* load_time_data);

47 void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data);	47 void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data);

48 void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data);	48 void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data);

49 void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);	49 void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);

50	50

	51 GURL learn_more_test_url_;
	meacer 2017/06/23 20:28:32 It seems like this variable isn't used (you have l It seems like this variable isn't used (you have local learn_more_test_url variables in the .cc file) sperigo 2017/06/23 21:32:12 Oops! Show quoted text On 2017/06/23 20:28:32, meacer wrote: > It seems like this variable isn't used (you have local learn_more_test_url > variables in the .cc file) Oops! sperigo 2017/06/23 21:32:12 Done. Show quoted text On 2017/06/23 20:28:32, meacer wrote: > It seems like this variable isn't used (you have local learn_more_test_url > variables in the .cc file) Done.
	52

51 DISALLOW_COPY_AND_ASSIGN(SafeBrowsingLoudErrorUI);	53 DISALLOW_COPY_AND_ASSIGN(SafeBrowsingLoudErrorUI);

52 };	54 };

53	55

54 } // security_interstitials	56 } // security_interstitials

55	57

56 #endif // COMPONENTS_SECURITY_INTERSTITIALS_CORE_SAFE_BROWSING_LOUD_ERROR_UI_H_	58 #endif // COMPONENTS_SECURITY_INTERSTITIALS_CORE_SAFE_BROWSING_LOUD_ERROR_UI_H_

OLD	NEW