Add regression tests from Luke's bug reports. Part 1.

Add regression tests from Luke's bug reports. Part 1.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/2434dc606ad4d158409defa228bcd2243109a99c

[ahe, 2017-06-22 14:06:25]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, paulberry@google.com

[ahe, 2017-06-22 14:40:01]

Please hold off reviewing this one, I've found a number of problems locally.

[ahe, 2017-06-23 10:11:09]

This is ready for review now.

[Johnni Winther, 2017-06-23 10:51:44]

lgtm

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/messages.dart (right):

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/messages.dart:104: Program program = new Program(
Maybe remove `Program program = ` and add a comment about the side effect of
creating a Program.

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
File pkg/front_end/testcases/regress/issue_29981.dart.outline.expect (right):

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
pkg/front_end/testcases/regress/issue_29981.dart.outline.expect:6: field
self::C<core::String> field;
Why `C<String>` and not `C<dynamic>` as type? What about the opposite case
`Map<String>` ?

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
File pkg/front_end/testcases/regress/issue_29983.dart.outline.expect (right):

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
pkg/front_end/testcases/regress/issue_29983.dart.outline.expect:4: static method
f() → dynamic
Shouldn't the type be `Iterable<dynamic>` ?

[ahe, 2017-06-23 12:21:51]

Thank you, Johhni!

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/messages.dart (right):

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/messages.dart:104: Program program = new Program(
On 2017/06/23 10:51:44, Johnni Winther wrote:
> Maybe remove `Program program = ` and add a comment about the side effect of
> creating a Program.

I've changed the code to make it more obvious. IMO.

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
File pkg/front_end/testcases/regress/issue_29981.dart.outline.expect (right):

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
pkg/front_end/testcases/regress/issue_29981.dart.outline.expect:6: field
self::C<core::String> field;
On 2017/06/23 10:51:44, Johnni Winther wrote:
> Why `C<String>` and not `C<dynamic>` as type? What about the opposite case
> `Map<String>` ?

I haven't put much though into this. C<dynamic> seems like throwing information
away. And for Map<String>, think we should generate Map<String, dynamic>, but
I'm not sure. Would you mind filing a bug if you have any concerns about this?

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
File pkg/front_end/testcases/regress/issue_29983.dart.outline.expect (right):

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
pkg/front_end/testcases/regress/issue_29983.dart.outline.expect:4: static method
f() → dynamic
On 2017/06/23 10:51:44, Johnni Winther wrote:
> Shouldn't the type be `Iterable<dynamic>` ?

I don't know. Perhaps in strong mode, but for outlines, I've assumed that async
markers don't affect the type.

[Johnni Winther, 2017-06-23 12:24:22]

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
File pkg/front_end/testcases/regress/issue_29981.dart.outline.expect (right):

https://codereview.chromium.org/2955443002/diff/20001/pkg/front_end/testcases...
pkg/front_end/testcases/regress/issue_29981.dart.outline.expect:6: field
self::C<core::String> field;
On 2017/06/23 12:21:51, ahe wrote:
> On 2017/06/23 10:51:44, Johnni Winther wrote:
> > Why `C<String>` and not `C<dynamic>` as type? What about the opposite case
> > `Map<String>` ?
> 
> I haven't put much though into this. C<dynamic> seems like throwing
information
> away. And for Map<String>, think we should generate Map<String, dynamic>, but
> I'm not sure. Would you mind filing a bug if you have any concerns about this?

In dart2js we use dynamic (we discussed it a long time ago when implementing
malformed types)

[ahe, 2017-06-23 12:25:31]

Description was changed from

==========
Add regression tests from Luke's bug reports. Part 1.
==========

to

==========
Add regression tests from Luke's bug reports. Part 1.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2434dc606ad4d158409defa228bcd2243109a99c
==========

[ahe, 2017-06-23 12:25:33]

Committed patchset #3 (id:40001) manually as
2434dc606ad4d158409defa228bcd2243109a99c.