Add regression tests from Luke's bug reports. Part 1.

pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE.md file.
 
 import 'package:front_end/src/base/instrumentation.dart';
 import 'package:front_end/src/dependency_walker.dart' as dependencyWalker;
 import 'package:front_end/src/fasta/errors.dart';
 import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart';
 import 'package:front_end/src/fasta/type_inference/type_inference_listener.dart';
 import 'package:front_end/src/fasta/type_inference/type_inferrer.dart';
 import 'package:front_end/src/fasta/type_inference/type_schema_environment.dart';
 import 'package:kernel/ast.dart'
     show
         Class,
         DartType,
         DynamicType,
         Field,
         FunctionType,
         InterfaceType,
+        Location,
         Member,
         Procedure,
         TypeParameter,
         TypeParameterType;
 import 'package:kernel/class_hierarchy.dart';
 import 'package:kernel/core_types.dart';
 import 'package:kernel/type_algebra.dart';
 
+import '../errors.dart' show Crash;
+
+import '../messages.dart' show getLocationFromNode;
+
 /// Data structure for tracking dependencies among fields, getters, and setters
 /// that require type inference.
 ///
 /// TODO(paulberry): see if it's possible to make this class more lightweight
 /// by changing the API so that the walker is passed to computeDependencies().
 /// (This should allow us to drop the _typeInferenceEngine field).
 class AccessorNode extends dependencyWalker.Node<AccessorNode> {
   final TypeInferenceEngineImpl _typeInferenceEngine;
 
   final KernelMember member;
@@ skipping 234 matching lines @@
     }
     for (var accessorNode in accessorNodes) {
       if (fusedTopLevelInference) {
         assert(expandedTopLevelInference);
         inferAccessorFused(accessorNode, null);
       } else {
         if (accessorNode.isEvaluated) continue;
         new _AccessorWalker().walk(accessorNode);
       }
     }
-    for (var formal in initializingFormals) {
-      formal.type = _inferInitializingFormalType(formal);
+    for (KernelVariableDeclaration formal in initializingFormals) {
+      try {
+        formal.type = _inferInitializingFormalType(formal);
+      } catch (e, s) {
+        Location location = getLocationFromNode(formal);
+        if (location == null) {
+          rethrow;
+        } else {
+          throw new Crash(Uri.parse(location.file), formal.fileOffset, e, s);
+        }
+      }
     }
   }
 
   /// Retrieve the [TypeInferrer] for the given [member], which was created by
   /// a previous call to [createTopLevelTypeInferrer].
   TypeInferrerImpl getMemberTypeInferrer(KernelMember member);
 
   /// Performs type inference on the given [accessorNode].
   void inferAccessor(AccessorNode accessorNode) {
     assert(accessorNode.state == InferenceState.NotInferredYet);
@@ skipping 322 matching lines @@
   }
 
   @override
   void evaluateScc(List<AccessorNode> scc) {
     // Mark every accessor as part of a circularity.
     for (var f in scc) {
       f._typeInferenceEngine.inferAccessorCircular(f);
     }
   }
 }