pkg/front_end/testcases/regress/issue_29981.dart.outline.expect - Issue 2955443002: Add regression tests from Luke's bug reports. Part 1.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/front_end/testcases/regress/issue_29981.dart.outline.expect

Issue 2955443002: Add regression tests from Luke's bug reports. Part 1. (Closed)

Patch Set: Fix type errors and incorrectly named tests. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« pkg/front_end/lib/src/fasta/messages.dart ('K') | « pkg/front_end/testcases/regress/issue_29981.dart ('k') | pkg/front_end/testcases/regress/issue_29982.dart » ('j') | pkg/front_end/testcases/regress/issue_29983.dart.outline.expect » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 library;

	2 import self as self;

	3 import "dart:core" as core;

	4

	5 class C<T extends core::Object> extends core::Object {

	6 field self::C<core::String> field;
	Johnni Winther 2017/06/23 10:51:44 Why `C<String>` and not `C<dynamic>` as type? What Why `C<String>` and not `C<dynamic>` as type? What about the opposite case `Map<String>` ? ahe 2017/06/23 12:21:51 I haven't put much though into this. C<dynamic> se Show quoted text On 2017/06/23 10:51:44, Johnni Winther wrote: > Why `C<String>` and not `C<dynamic>` as type? What about the opposite case > `Map<String>` ? I haven't put much though into this. C<dynamic> seems like throwing information away. And for Map<String>, think we should generate Map<String, dynamic>, but I'm not sure. Would you mind filing a bug if you have any concerns about this? Johnni Winther 2017/06/23 12:24:22 In dart2js we use dynamic (we discussed it a long Show quoted text On 2017/06/23 12:21:51, ahe wrote: > On 2017/06/23 10:51:44, Johnni Winther wrote: > > Why `C<String>` and not `C<dynamic>` as type? What about the opposite case > > `Map<String>` ? > > I haven't put much though into this. C<dynamic> seems like throwing information > away. And for Map<String>, think we should generate Map<String, dynamic>, but > I'm not sure. Would you mind filing a bug if you have any concerns about this? In dart2js we use dynamic (we discussed it a long time ago when implementing malformed types)
	7 constructor •() → void

	8 ;

	9 }

	10 static method main() → dynamic

	11 ;

OLD	NEW