Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Issue 2955263002: [Payment Request] Moves some of PR coordinator logic to PR manager (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
Reviewers:
macourteau
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Moves some of PR coordinator logic to PR manager Moves translation of autofill::AutofillProfile to payments::PaymentAddress from PaymentRequestCoordinator into the PaymentRequestManager. BUG=602666 Review-Url: https://codereview.chromium.org/2955263002 Cr-Commit-Position: refs/heads/master@{#482979} Committed: https://chromium.googlesource.com/chromium/src/+/8d0adb0a32053ae5be48a551c6f59abff6b89a2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -51 lines) Patch
M ios/chrome/browser/ui/payments/payment_request_coordinator.h View 2 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator.mm View 4 chunks +3 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator_unittest.mm View 4 chunks +22 lines, -31 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_manager.mm View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Moe
Hi MAC, Please take a look.
3 years, 5 months ago (2017-06-28 02:25:04 UTC) #2
macourteau
lgtm, nice :)
3 years, 5 months ago (2017-06-28 14:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955263002/1
3 years, 5 months ago (2017-06-28 14:07:36 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 14:22:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d0adb0a32053ae5be48a551c6f5...

Powered by Google App Engine
This is Rietveld 408576698